Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove umbrella omniauth-saml advisory in favor of linked ruby-saml advisories. #5625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

postmodern
Copy link

GHSA-hw46-3hmr-x9xv claims to affect omniauth-saml, however it only mentions three other ruby-saml advisories and recommends upgrading ruby-saml. I see no evidence that there is a vulnerability in omniauth-saml specifically.

* `GHSA-hw46-3hmr-x9xv` claims to affect `omniauth-saml`, however it only
  mentions three other `ruby-saml` advisories and recommends upgrading
  `ruby-saml`.
@github-actions github-actions bot changed the base branch from main to postmodern/advisory-improvement-5625 May 22, 2025 21:50
@shelbyc
Copy link
Contributor

shelbyc commented May 23, 2025

Hi @postmodern, GHSA-hw46-3hmr-x9xv is an advisory in which the maintainers of omniauth-saml discussed how the GHSA-4vc4-m8qh-g8jm, GHSA-754f-8gm6-c4r2, and GHSA-92rq-c8cf-prrq vulnerabilities from ruby-saml affected their product. There aren't duplicate alerts because GHSA-4vc4-m8qh-g8jm, GHSA-754f-8gm6-c4r2, and GHSA-92rq-c8cf-prrq issue alerts for ruby-saml and GHSA-hw46-3hmr-x9xv issues alerts for omniauth-saml, so it's OK for the maintainers of omniauth-saml to have a separate advisory to discuss how three vulnerabilities affect their product. Thanks for your interest in GHSA-hw46-3hmr-x9xv and have a good weekend!

@shelbyc shelbyc closed this May 23, 2025
@postmodern
Copy link
Author

Hi @shelbyc, the three mentioned ruby-saml vulnerabilities can easily be fixed by upgrading the ruby-saml dependency of the omniauth-saml gem by running gem update ruby-saml or bundle update ruby-saml since omniauth-saml uses an up-ended ~> X.Y version constraint for ruby-saml. There is no need to upgrade omniauth-saml or issue a separate advisory due to an issue with one of it's dependencies that can be upgraded separately.

GHSA and CVE advisories should be created for specific vulnerable software versions, not other software which may use another vulnerable piece of software as dependencies, otherwise we would have an explosion of new advisories which simply reference other advisories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants