Thanks to visit codestin.com
Credit goes to github.com

Skip to content

added 'csrf-field' optional attribute. #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 4, 2021
Merged

added 'csrf-field' optional attribute. #54

merged 5 commits into from
Aug 4, 2021

Conversation

eroluysal
Copy link
Contributor

No description provided.

@eroluysal eroluysal requested a review from a team as a code owner August 1, 2021 16:10
@eroluysal eroluysal changed the title added 'csrfFieldName' optional attribute. added 'csrf-field' optional attribute. Aug 1, 2021
@dgreif
Copy link

dgreif commented Aug 2, 2021

@eroluysal would you mind providing some context as to why you need this change?

@eroluysal
Copy link
Contributor Author

eroluysal commented Aug 2, 2021 •
edited
Loading

@dgreif I guess "authenticity_token" is specific for Rails framework. for example; I want to use auto-complete-element with Symfony framework and Symfony framework uses "_token" parameter name for csrf validation.

koddsson
koddsson approved these changes Aug 4, 2021
View reviewed changes
Copy link
Contributor

@koddsson koddsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good to me after the suggested changes from me.

I wasn't sure if adding csrfField to the API for the component makes sense, but I think it does in the end.

koddsson
koddsson reviewed Aug 4, 2021
View reviewed changes
@koddsson koddsson merged commit 95d939d into github:main Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koddsson koddsson koddsson approved these changes

@JoseInTheArena JoseInTheArena Awaiting requested review from JoseInTheArena JoseInTheArena was automatically assigned from github/web-systems-reviewers

@VanAnderson VanAnderson Awaiting requested review from VanAnderson VanAnderson was automatically assigned from github/web-systems-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eroluysal @dgreif @koddsson