Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add fetch-on-empty optional attribute #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 30, 2023
Merged

Add fetch-on-empty optional attribute #100

merged 5 commits into from
Mar 30, 2023

Conversation

loisolire
Copy link
Contributor

@loisolire loisolire commented Jan 18, 2023 •
edited
Loading

This attribute, when set, allows the auto-complete-element to fetch results with empty query value.

@loisolire loisolire changed the title Add extra condition for fetching empty queries. Add fetch-on-empty optional attribute Jan 18, 2023
@loisolire loisolire force-pushed the allow-empty-query-search branch from 275f6c1 to 78bc5c4 Compare January 18, 2023 10:53
@loisolire loisolire marked this pull request as ready for review January 18, 2023 10:54
@loisolire loisolire requested a review from a team as a code owner January 18, 2023 10:54
@primer-css
Copy link

👋 Hello and thanks for pinging us! This issue or PR has been added to our inbox and a Design Infrastructure first responder will review it soon.

  • 🎨 If this is a PR that includes a visual change, please make sure to add screenshots in the description or deploy this code to a lab machine with instructions for how to test.
  • ⏩ If this is a PR that includes changes to an interaction, please include a video recording in the description.
  • ⚠️ If this is urgent, please visit us in #primer on Slack and tag the first responders listed in the channel topic.

keithamus
keithamus approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good addition 👍

@MaximeRnR
Copy link
Contributor

Do we have a idea for when it will be merged ^^ ?

keithamus
keithamus reviewed Jan 25, 2023
View reviewed changes
loisolire and others added 4 commits February 10, 2023 11:25
@loisolire @MaximeRnR
Add fetch-on-empty optional attribute
5301a0a 
This attribute, when set, allows the auto-complete-element to fetch results with empty query value.

Co-authored-by: Maxime Reynier <[email protected]>
@keithamus @loisolire
use toggleAttribute
44eb399
@keithamus @loisolire
add additional test asserting removal of fetch-on-empty results in no…
80a4873 
… fetch
@keithamus @loisolire
prettier
d9c7cc7
@loisolire loisolire force-pushed the allow-empty-query-search branch from 79c9f3f to d9c7cc7 Compare February 10, 2023 10:25
@MaximeRnR
Copy link
Contributor

Hello, do we have any idea when this will be merged ? Thanks a lot for your time !

@keithamus
Copy link
Contributor

Apologies, this should have been handled by the first responder staff member in rotation on January.

@keithamus keithamus merged commit a058977 into github:main Mar 30, 2023
@keithamus
Copy link
Contributor

This has been released as v3.4.0. Thanks for your efforts @loisolire! Thanks for bumping this @MaximeRnR

@MaximeRnR
Copy link
Contributor

Thx for your quick answer !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithamus keithamus keithamus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@loisolire @primer-css @MaximeRnR @keithamus