Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Imperative and shadow element definitions #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 21, 2023
Merged

Imperative and shadow element definitions #103

merged 2 commits into from
Apr 21, 2023

Conversation

keithamus
Copy link
Contributor

@keithamus keithamus commented Mar 30, 2023 •
edited
Loading

Extending from @augonis's work in #95 this adds imperative element assignment to the for and input elements, which allows for cross-root elements. It also adds tests to ensure this works in the shadowdom.

Fixes #38, closes #95

@keithamus keithamus requested a review from a team as a code owner March 30, 2023 11:13
@keithamus keithamus force-pushed the imperative-and-shadow-element-definitions branch 2 times, most recently from 247d421 to dae2068 Compare March 30, 2023 11:14
augonis and others added 2 commits March 30, 2023 12:16
@augonis @keithamus
Fixes #38
b02a30a 
Replaces usages of `document.getElementById` with `container.querySelector`
@keithamus
allow imperative defining of associated elements
f14f04d
@keithamus keithamus force-pushed the imperative-and-shadow-element-definitions branch from dae2068 to f14f04d Compare March 30, 2023 11:18
@primer-css
Copy link

👋 Hello and thanks for pinging us! This issue or PR has been added to our inbox and a Design Infrastructure first responder will review it soon.

  • 🎨 If this is a PR that includes a visual change, please make sure to add screenshots in the description or deploy this code to a lab machine with instructions for how to test.
  • ⏩ If this is a PR that includes changes to an interaction, please include a video recording in the description.
  • ⚠️ If this is urgent, please visit us in #primer on Slack and tag the first responders listed in the channel topic.

@keithamus keithamus merged commit f3c8e75 into main Apr 21, 2023
@keithamus keithamus deleted the imperative-and-shadow-element-definitions branch April 21, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshBowdenConcepts JoshBowdenConcepts JoshBowdenConcepts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Input cannot be found if javascript is run before element is present
4 participants
@keithamus @primer-css @JoshBowdenConcepts @augonis