Replace keyboard binding code with combobox-nav#15
Merged
Conversation
muan
commented
Jan 7, 2019
| const input = this.querySelector('input') | ||
| const results = document.getElementById(owns) | ||
| if (!(input instanceof HTMLInputElement) || !results) return | ||
| input.setAttribute('aria-owns', owns) |
Contributor
Author
There was a problem hiding this comment.
combobox-nav requires aria-owns relationship to be on input & list since it is unaware of the parent element. This copies auto-complete[aria-owns] onto input.
| }) | ||
| e.key = key | ||
| if (key !== key.toLowerCase()) e.shiftKey = true | ||
| if (key.length === 1 && key !== key.toLowerCase()) e.shiftKey = true |
Contributor
Author
There was a problem hiding this comment.
shiftKey was true on ArrowDown and others but it should not.
koddsson
approved these changes
Jan 8, 2019
keithamus
approved these changes
Jan 15, 2019
dgraham
approved these changes
Jan 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So that we won't need to sync up this kind - of fixes.