Pull request suggestions #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inkblotty
reviewed
Nov 12, 2021
|
|
||
| triggerInput(input, 'hub') | ||
| await once(container, 'loadend') | ||
| await once(container, 'sr-update') | ||
| await waitForElementToChange(feedback) |
By inlining the screen reader announcement text we remove a layer of indirection.
The event fired has no effect in production which indicates that it shouldn't be in the code at all. What we want to do in the tests is to wait for the feedback element to have text so we should instead use a MutationObserver to wait for the element to change before running our assertion.
We remove a level of indirection by inlining the list box ID. It's more apparent to the reader of the tests what elements are being referred to without having to find the definition of the `listboxId` variable.
b609be8 to
35dc743
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.