Update repository backups to use ghe-gc-* for lock file management #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice. My plan is to skip this for the next patch release and include the refactor in the next minor though, if that sounds good. |
|
@rubiojr Sounds good. I have a few other PR's landing soon that are also non-urgent and are best left until the next minor. |
|
|
zachary-mark
pushed a commit
that referenced
this pull request
May 3, 2021
Replace redis-cli with ghe-redis-cli
Merged
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the repository backup scripts to use the
ghe-gc-enableandghe-gc-disablescripts for managing the.sync_in_progresslock file.These were introduced in #179 and are already used by the restore equivalents.
/cc @github/backup-utils