WIP: Reducing gist backup timings #540
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
version call outside of the loop should greatly reduce time per discussions with @piki this will be related to https://github.com/github/ghes-infrastructure/issues/243
|
additional testing required before merging. |
got a linting rule failure for 'share/github-backup-utils/ghe-backup-repositories-rsync:373:11: warning: Declare and assign separately to avoid masking return values. [SC2155]' seeing if it plays nicer with out local.
|
for those learning the version call is here in ghe config |
Co-Authored-By: Matthias Wiesen <[email protected]>
Co-Authored-By: Matthias Wiesen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reducing processing time by move the pure function
versionoutside of the loop. This will reduce the number of calls to a static 5 from 5*N.