Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

jianghao0718
Copy link
Contributor

@jianghao0718 jianghao0718 commented Feb 20, 2020

Regression found by @lildude

In legacy mode we should use ghe-import-mysql since ghe-import-mysql-mysqldump doesn't exist for 2.18 / 2.19.4 or earlier

/cc @lildude @oakeyc @DanRigby @ipmsteven

In legacy mode we should use ghe-import-mysql
Copy link
Contributor

@DanRigby DanRigby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. :shipit:

@jianghao0718
Copy link
Contributor Author

Test ran against this topic branch with 2.18 and 2.19 to ensure the back-compatibility

@jianghao0718 jianghao0718 merged commit 45acc1b into master Feb 20, 2020
@cainejette cainejette mentioned this pull request Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants