Beta: Execute ghe-restore tasks in parallel #601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5a5b659 to
bde8ae9
Compare
6a47bf3 to
d263c8a
Compare
775123b to
21c22e3
Compare
495c243 to
71b4e67
Compare
21c22e3 to
4a49554
Compare
71b4e67 to
01cabcd
Compare
4a49554 to
fa01a30
Compare
01cabcd to
53912d8
Compare
fa01a30 to
1eea224
Compare
53912d8 to
c8eccf8
Compare
2c89a01 to
0883e2a
Compare
0883e2a to
dcee3b0
Compare
ryansimmen
commented
Apr 7, 2020
| ghe-ssh "$GHE_HOSTNAME" -- /bin/bash 1>&3 | ||
| done | ||
|
|
||
| ghe-ssh "$GHE_HOSTNAME" -- "sudo sh -c 'rm $GHE_REMOTE_DATA_USER_DIR/elasticsearch-restore/*.gz'" 1>&3 |
There was a problem hiding this comment.
When both ghe-restore-es-audit-log and ghe-restore-es-hookshot run at the same time during parallel restore, there is a race condition whereupon ghe-ssh "$GHE_HOSTNAME" -- "sudo sh -c 'rm $GHE_REMOTE_DATA_USER_DIR/elasticsearch-restore/*.gz'" 1>&3 from one script deletes the *.gz files that the other script had put down. I moved these files to separate directories so this wouldn't happen and my fix for the single-vm or configured edge case is to copy all files to the elasticsearch-restore folder so elasticsearch-post-start will process them accordingly.
ewgenius
approved these changes
Apr 7, 2020
amildahl
pushed a commit
that referenced
this pull request
Nov 28, 2023
reverting changes to redis restart mechanism
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Execute long running restore tasks in parallel by leveraging moreutils parallel.
This resolves https://github.com/github/ghes-infrastructure/issues/407
Most of this work is based upon work done in #597