remove rsync restore method used by GHES versions prior to 2.13 #608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GHES 2.13 is already out of support and therefore I think we should remove the code. Furthermore the `ghe-restore-pages-rsync` script uses `share/github-backup-utils/ghe-restore-userdata` which I think does not quote/escape the variable `$dirname` properly. As a consequence GitHub pages with whitespaces in their path cause errors on restore.
|
Пошёл нахуй дебил
Отправлено с iPhone
… 18 мая 2020 г., в 16:50, Hao Jiang ***@***.***> написал(а):
@jianghao0718 approved this pull request.
LGTM!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
@cainejette I can confirm a successful backup and restore procedure with the latest $ git log --oneline -1
71cd8f6 (HEAD -> master, origin/master, origin/HEAD) Merge pull request #608 from github/ls/remove-old-code
$ ./bin/ghe-backup
Starting backup of larsxschneider-025895a7445ef9d59.ghe-test.org with backup-utils v2.20.2 in snapshot 20200524T160204
Connect larsxschneider-025895a7445ef9d59.ghe-test.org:122 OK (v2.20.8)
Backing up GitHub settings ...
Backing up SSH authorized keys ...
Backing up SSH host keys ...
Backing up MySQL database using logical backup strategy ...
Backing up Redis database ...
Backing up audit log ...
Backing up hookshot logs ...
Backing up Git repositories ...
Backing up GitHub Pages artifacts ...
Backing up storage data ...
Warning: no routes found, skipping storage backup ...
Backing up custom Git hooks ...
Backing up Elasticsearch indices ...
Completed backup of larsxschneider-025895a7445ef9d59.ghe-test.org:122 in snapshot 20200524T160204 at 16:02:34
Checking for leaked ssh keys ...
* No leaked keys found
$ ./bin/ghe-restore -f larsxschneider-025895a7445ef9d59.ghe-test.org
Checking for leaked keys in the backup snapshot that is being restored ...
* No leaked keys found
Connect larsxschneider-025895a7445ef9d59.ghe-test.org:122 OK (v2.20.8)
Starting restore of larsxschneider-025895a7445ef9d59.ghe-test.org:122 with backup-utils v2.20.2 from snapshot 20200524T160204
Stopping cron and github-timerd ...
Restoring UUID ...
Restoring MySQL database from logical backup snapshot on an appliance configured for logical backups ...
Restoring Redis database ...
Restoring Git repositories ...
Restoring Gists ...
Warning: Gist backup missing. Skipping ...
Restoring GitHub Pages artifacts ...
Restoring SSH authorized keys ...
Restoring storage data ...
Restoring custom Git hooks ...
Restoring Elasticsearch indices ...
Restoring Audit logs ...
Restoring hookshot logs ...
Configuring appliance ...
Starting cron ...
Restoring SSH host keys ...
Restore of larsxschneider-025895a7445ef9d59.ghe-test.org:122 from snapshot 20200524T160204 finished. |
|
Thanks for doing that validation, @larsxschneider ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GHES 2.13 is already out of support and therefore I think we should
remove the code.
Furthermore the
ghe-restore-pages-rsyncscript usesshare/github-backup-utils/ghe-restore-userdatawhich I think does notquote/escape the variable
$dirnameproperly. As a consequence GitHubpages with whitespaces in their path cause errors on restore.