Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update backup-utils for new features in 2.22 #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 446 commits into from
Sep 23, 2020
Merged

Update backup-utils for new features in 2.22 #641

Changes from 1 commit
Commits
Show all changes
446 commits
Select commit Hold shift + click to select a range
16473e3
Merge branch 'master' into sridharavinash/ghe-cluster-hostname-filter
lildude Jan 11, 2018
9620322
Simplify cmd to get hostnames
lildude Jan 11, 2018
0b0b432
Aesthetics and words
lildude Jan 11, 2018
cc5833a
Test old hostname response
lildude Jan 11, 2018
8a811d2
Use ghe-cluster-nodes for alambic-ng backup [ci only enterprise2-clus…
lildude Jan 11, 2018
7416480
Pull in fix from github/backup-utils/pull/364
lildude Jan 11, 2018
da9aae6
Remove older versions to speed up testing
lildude Jan 11, 2018
a247c6f
Revert "Remove older versions to speed up testing"
lildude Jan 11, 2018
3de1463
Don't run tests when testing building deb pkg
lildude Jan 11, 2018
740b6d0
Revert "Pull in fix from github/backup-utils/pull/364"
lildude Jan 11, 2018
c479376
Remove unused test script
lildude Jan 11, 2018
9fcd954
Remove symlink
lildude Jan 11, 2018
ad73fb0
Call directly
lildude Jan 11, 2018
93456f8
Add comments
lildude Jan 11, 2018
39dd6d6
Merge pull request #89 from github/sridharavinash/ghe-cluster-hostnam…
lildude Jan 16, 2018
f6e306b
Merge remote-tracking branch 'upstream/master' into lildude/update-fr…
lildude Jan 18, 2018
62289a1
Merge pull request #123 from github/lildude/update-from-public
lildude Jan 22, 2018
3d6a12a
Merge branch 'master' of github.com:github/backup-utils into lildude/…
lildude Feb 16, 2018
6054f1f
Merge pull request #124 from github/lildude/sync-with-public
lildude Feb 16, 2018
66cad33
remove indices created with ES 1.x
juruen Jan 31, 2018
561e998
remove ES 1.x indices in >=2.14
juruen Mar 1, 2018
cf441f4
Merge pull request #125 from github/juruen/remove-1x-indices
juruen Mar 2, 2018
97bc3c5
Merge branch 'master' into lildude/unify-strategy
lildude Mar 21, 2018
a18040d
No need for version differentiation
lildude Mar 21, 2018
5cbc8fb
Use local variables
lildude Mar 21, 2018
93359f5
Bump version to 2.13.0
lildude Mar 21, 2018
03292d5
Merge pull request #127 from github/lildude/unify-strategy
lildude Mar 21, 2018
a2b46f6
Add a version helper function
lildude Mar 22, 2018
d4d27d4
Relax min version req for 2.11 and 2.12
lildude Mar 22, 2018
01678d6
Still use old rsync method prior to 2.13 on single nodes
lildude Mar 22, 2018
cb2c062
Restore exported JSON audit and hookshot logs to 2.12.9 onwards
lildude Mar 22, 2018
2d92a15
Test 2.11 and 2.13
lildude Mar 22, 2018
66249ff
Add 2.14 for future release testing
lildude Mar 22, 2018
09cdf98
Merge pull request #129 from github/lildude/relax-211-212-min-reqs
lildude Mar 22, 2018
53eeaf7
Handle dev and test GHE versions
lildude Mar 23, 2018
d0e1e39
Allow for any version above minimum
lildude Mar 23, 2018
af28b71
Merge pull request #132 from github/lildude/handle-dev-test-versions
lildude Mar 23, 2018
24caccc
Merge pull request #133 from github/lildude/sync-with-public
lildude Apr 6, 2018
d3175a2
Merge remote-tracking branch 'upstream/master' into lildude/syncy-dink
lildude May 11, 2018
cfdfb01
Merge pull request #138 from github/lildude/syncy-dink
lildude May 12, 2018
a546fe2
Merge remote-tracking branch 'public/master'
dbussink Oct 9, 2018
219c96a
Merge remote-tracking branch 'origin/master' into snh-sync
snh Feb 5, 2020
0bab374
Merge pull request #159 from github/snh-sync
snh Feb 5, 2020
a413701
CI with GitHub Actions
djdefi Feb 12, 2020
39c4d28
Merge pull request #161 from github/djdefi-actionable
djdefi Feb 20, 2020
df8678a
Add mssql backup portion
ritchxu Feb 5, 2020
be2bd01
Create hard links for backup files
ritchxu Feb 6, 2020
e19d978
Add restore part
ritchxu Feb 7, 2020
00efedf
Use ghe_verbose and PR comments
ritchxu Feb 10, 2020
98bf12b
Add documentation
ritchxu Feb 10, 2020
89aecf5
Use verbose flag to control ghe-export-mssql output
dhadka Feb 11, 2020
1d1a494
Add test coverage
ritchxu Feb 12, 2020
ddd1f98
Always return available for test
ritchxu Feb 21, 2020
aaf4cb9
Fix subtract_minute for Linux
ritchxu Feb 21, 2020
ba65c8f
Fix cross-plat regex
ritchxu Feb 21, 2020
94d33d7
Fix issues found by shellcheck
ritchxu Feb 21, 2020
8a32116
Merge remote-tracking branch 'upstream/master'
jianghao0718 May 29, 2020
adfdc07
Fix main.yml to get test pass
jianghao0718 Jun 2, 2020
16201da
Merge pull request #164 from github/hao/sync-private-to-public
jianghao0718 Jun 2, 2020
ff2eee0
Add external service check, for mysql only now.
omgitsads Jun 3, 2020
e0800da
Execute backup script and exit early from `ghe-backup-mysql`
omgitsads Jun 3, 2020
187c29f
Finish the benchmark before exiting
omgitsads Jun 3, 2020
d4b730f
Newline at end of file
omgitsads Jun 3, 2020
822df78
Set default value to /bin/false. Mysql backups will fail until changed.
omgitsads Jun 3, 2020
e6f7a1d
Logging and backup script check
omgitsads Jun 3, 2020
97ee985
Remove comment
omgitsads Jun 3, 2020
7d0904d
Backup and restore the external mysql password
omgitsads Jun 4, 2020
1c15d0d
Fix syntax error
omgitsads Jun 4, 2020
c84db01
Restore the MySQL password before importing settings
omgitsads Jun 4, 2020
73ed1c7
Add restore entry point
jianghao0718 Jun 4, 2020
32d4eec
A few updates to ghe-backup and ghe-restore
jianghao0718 Jun 4, 2020
d059b2a
Add local file support for is_service_external
omgitsads Jun 5, 2020
e09bfa3
Use the settings file in the snapshot to determine external db
omgitsads Jun 5, 2020
7f9b059
Remove expectation of having the mysql data in the snapshot
omgitsads Jun 5, 2020
6bdf349
Merge remote-tracking branch 'upstream/master'
ipmsteven Jun 5, 2020
956d127
Export GHE_DATA_DIR in ghe-backup-config so it will be available to c…
jianghao0718 Jun 5, 2020
6cb2b67
Do not require customer to use standard output for backup script
jianghao0718 Jun 5, 2020
5d92693
A few minor edits
jianghao0718 Jun 5, 2020
9ec815e
Export `GHE_RESTORE_SNAPSHOT` for use in custom script
omgitsads Jun 8, 2020
fe540ac
Merge pull request #165 from github/byodb-client-hooks
omgitsads Jun 8, 2020
f1e4947
Add --skip-mysql flag and check for compatability of snapshots
omgitsads Jun 9, 2020
b71e25b
Fix syntax errors and move mysql skipping to ghe-restore
omgitsads Jun 10, 2020
1b5a095
Rename and export arguments for use in child scripts
omgitsads Jun 10, 2020
a6b12d6
Add support for github.conf to ghe-config stub, tests for external db
omgitsads Jun 11, 2020
48ab833
Fix shellcheck issue
omgitsads Jun 11, 2020
4404e6a
Use configured helper
omgitsads Jun 11, 2020
1670e57
Add test for external db snapshot to external db instance
omgitsads Jun 11, 2020
821efee
Add test for non-external -> external with --skip-mysql
omgitsads Jun 12, 2020
66963d5
Add test for external db snapshot -> non external with --skip-mysql
omgitsads Jun 12, 2020
b83b00c
Newline
omgitsads Jun 12, 2020
d6ae1e6
Rename to be more consistent with other checks
omgitsads Jun 12, 2020
9361e9e
Remove bash -x, add tests when restoring settings
omgitsads Jun 12, 2020
9999ed9
Add test for RESTORE_SETTINGS to the external restore check
omgitsads Jun 12, 2020
2665f6e
Committed unintentionally
omgitsads Jun 12, 2020
d84118a
Extract external DB checks to seperate script.
omgitsads Jun 19, 2020
0937936
Add checks for mysql nodes when restoring settings.
omgitsads Jun 19, 2020
49e5528
Uncomment the tests that were accidentally commented
omgitsads Jun 19, 2020
539d80a
Add support for role check in ghe-cluster-each.
omgitsads Jun 22, 2020
0a1aa67
Add test asserting warning for left over mysql node.
omgitsads Jun 22, 2020
67bab12
Uncomment all tests
omgitsads Jun 22, 2020
ea5fad4
set -e
omgitsads Jun 22, 2020
1cb20cf
Update README with note about --skip-mysql flag in ghe-restore
cainejette Jun 22, 2020
252f30e
Add comments to is_service_external
cainejette Jun 22, 2020
1d12ec3
Add comment to check_external_database_snapshot_compatibility
cainejette Jun 22, 2020
2339428
indent check_external_db_compatibility
cainejette Jun 22, 2020
6debbfe
Update comments in check_external_db_compatibility
cainejette Jun 22, 2020
d1b66c7
Reduce 3 line comment to 2 lines
cainejette Jun 22, 2020
23b9e29
Add some function level comments for verbosity
cainejette Jun 22, 2020
e5351af
Change text from 'post-restore' to 'after the restore has completed'
cainejette Jun 22, 2020
5ee46e4
Add comment to ghe-restore-external-database-check
cainejette Jun 22, 2020
1147a41
Update comment about is_external_database_target_or_snapshot
cainejette Jun 22, 2020
11b99b5
Add newline to end of ghe-backup-config file
cainejette Jun 22, 2020
d25038c
Update share/github-backup-utils/ghe-restore-external-database-check
omgitsads Jun 23, 2020
9aace6d
Sync with from public repo - https://github.com/github/backup-utils/p…
ewgenius Jun 23, 2020
08f8062
Add comments explaining ghe-restore-external-database-check
cainejette Jun 23, 2020
d30deb2
Switch order of conditions
cainejette Jun 23, 2020
0e024c5
Merge pull request #168 from github/ewgenius/sync-with-public
cainejette Jun 24, 2020
1dbb540
properly pipe stderr from restore command; fix test output
Jun 24, 2020
4606b26
Merge branch 'master' of github.com:github/backup-utils-private into …
ewgenius Jun 25, 2020
67fb730
fix test string
Jun 25, 2020
db62fb2
fix lint warning
Jun 25, 2020
9c6e479
Change to is_external_database_target and is_external_database_snapshot
omgitsads Jun 25, 2020
133e93e
Check for both with skip mysql
omgitsads Jun 25, 2020
364b5e9
Check for MySQL master
omgitsads Jun 25, 2020
7458e2e
Add check for cluster.mysql-master
omgitsads Jun 25, 2020
9fe9209
Remove extra testing loop
cainejette Jun 25, 2020
ce657dd
Prevent skipping mysql restore for non-external configuration
Jun 25, 2020
2f768c8
Merge pull request #169 from github/remove-extra-testing-loop
cainejette Jun 26, 2020
5f8682f
Revert "Prevent skipping mysql restore for non-external configuration"
ewgenius Jun 26, 2020
6dbab2c
Error out if mysql-server/mysql-master are in cluster config when res…
cainejette Jun 26, 2020
5e396bf
fix test strings
Jun 26, 2020
e42940f
FF backup/restore
ritchxu Jun 29, 2020
38b61e2
Merge branch 'master' into mssql-backup
ritchxu Jun 29, 2020
4d9a925
Validate enabled path in tests
ritchxu Jun 29, 2020
6225e43
Revert "Validate enabled path in tests"
ritchxu Jun 29, 2020
c39b5a4
Revert "FF backup/restore"
ritchxu Jun 29, 2020
bfc7153
Another attempt in FF backup/restore
ritchxu Jun 29, 2020
f3090f0
Fix tests
ritchxu Jun 29, 2020
3ecab41
Exit when attempting to restore settings and changing BYODB state
cainejette Jun 29, 2020
c3dd3bb
Rework ghe-restore-external-database-check
cainejette Jun 29, 2020
9eb8c13
Rearrange usage text
cainejette Jun 30, 2020
f042323
Rename ghe-restore-external-database-check
cainejette Jun 30, 2020
4c7fffd
Update usage.md
cainejette Jun 30, 2020
b4f6189
Update ghe-restore -c tests to look for correct output
cainejette Jun 30, 2020
e85bd9c
Fix whitespace
cainejette Jun 30, 2020
ff0d069
Add comment about is_service_external
cainejette Jun 30, 2020
d288656
Delete outdated tests
cainejette Jun 30, 2020
8cb6516
Add tests validating error message when omitting --skip-mysql
cainejette Jun 30, 2020
217ffaf
Add test helper methods for setting BYODB state of backup snapshot an…
cainejette Jun 30, 2020
eef42d9
Add wrapper for outputting debug logs and failing test
cainejette Jun 30, 2020
cf02425
Add helper for checking restore output
cainejette Jun 30, 2020
1a3d078
Remove extraneous exit 0s
cainejette Jun 30, 2020
a8f49a1
Fix output redirection
cainejette Jun 30, 2020
3c40af6
Merge branch 'master' into byodb-to-non-byodb
cainejette Jun 30, 2020
fb75861
Test removing explicit SKIP_MYSQL=true statements
cainejette Jun 30, 2020
3ad09e8
Add back SKIP_MYSQL declarations
cainejette Jun 30, 2020
eb4c3b1
Change -z test to directly evaluating SKIP_MYSQL variable value
cainejette Jun 30, 2020
9653904
Comment indicating why we have to manually set SKIP_MYSQL=true
cainejette Jul 1, 2020
b276b35
Remove quotes
cainejette Jul 1, 2020
c102adb
Merge pull request #167 from github/byodb-to-non-byodb
cainejette Jul 1, 2020
48efd36
Adds support for backing up Actions files
dhadka Jul 2, 2020
2521ebc
Fix tests
dhadka Jul 2, 2020
6e47715
Warn if database names changed
ritchxu Jul 6, 2020
19345fa
Merge branch 'master' into mssql-backup
ritchxu Jul 6, 2020
84730c5
Add confirmation prompt when restoring BYODB snapshot to unconfigured…
cainejette Jul 6, 2020
1e4e5f0
Add test for mismatch check
ritchxu Jul 7, 2020
2ac08f1
Add BYODB-specific warning when restoring settings
cainejette Jul 7, 2020
f82ee05
Hide warning if --force passed
cainejette Jul 7, 2020
ec53cbd
Re-order conditionals
cainejette Jul 7, 2020
597e3ae
Add extra WARNING text
cainejette Jul 7, 2020
7d9d867
Add extra empty line
cainejette Jul 7, 2020
dfbdec6
Update wording to match other confirmation prompt
cainejette Jul 7, 2020
f079f1c
Pull prompt logic into its own function for reuse
cainejette Jul 7, 2020
9d9ffa1
Add newline to end of file
cainejette Jul 7, 2020
7882d41
Move empty line to first warning so its shown even if second warning …
cainejette Jul 7, 2020
4cd9ae3
Merge pull request #171 from github/restore-byodb-connection-info-war…
cainejette Jul 8, 2020
625b27d
Extract out binary and logical backup processes
omgitsads Jul 8, 2020
82b3516
Split mysql restore scripts to binary and logical
omgitsads Jul 8, 2020
8e62736
External database support
omgitsads Jul 8, 2020
4a353fc
Somehow all the capitals got lost :sadpanda:
omgitsads Jul 8, 2020
3f7c687
fix syntax error
omgitsads Jul 8, 2020
77dc63a
Set correct permissions on new files
omgitsads Jul 8, 2020
ef0a779
Need to pass the hostname
omgitsads Jul 8, 2020
02e0255
Also backup and restore settings
dhadka Jul 8, 2020
134e079
Remove cluster mode
dhadka Jul 8, 2020
757c717
Fix test
dhadka Jul 8, 2020
f1d6f37
React to feedback
dhadka Jul 9, 2020
d81ead8
Fix bash compat issue on Mac
dhadka Jul 9, 2020
cfaa9ee
Undo unintended changes
dhadka Jul 9, 2020
8c9b1c9
Exit from mysql scripts early if we are running the external scripts
omgitsads Jul 9, 2020
5036f92
prperly use pigz for logical mysql export, instead of binary
Jul 9, 2020
2ecab27
Fix comments
omgitsads Jul 14, 2020
88af4f7
Merge pull request #160 from github/mssql-backup
ritchxu Jul 14, 2020
e343a20
Merge pull request #170 from github/actions-backup
dhadka Jul 14, 2020
a725408
Add a legacy script until 2.22 ships
omgitsads Jul 14, 2020
4eb0eb9
Warn rather than error on binary settings, then run logical.
omgitsads Jul 14, 2020
1551414
Prevent leaking MSSQL backup files to subsequent tests
dhadka Jul 14, 2020
62b8457
Merge pull request #174 from github/dhadka/fix-tests
dhadka Jul 14, 2020
ab36713
Add new lines to ends of files
cainejette Jul 14, 2020
26fdca9
Add some extra verbosity to file comments
cainejette Jul 14, 2020
54ee324
Fix typo in Actions secret
dhadka Jul 14, 2020
b26f221
Merge pull request #175 from github/dhadka/fix-typo
dhadka Jul 14, 2020
e6fe594
Detech if backup has sentinel or not, and warn differently
omgitsads Jul 15, 2020
684a625
Merge branch 'default-external-database-scripts' of github.com:github…
omgitsads Jul 15, 2020
40bd3f8
Change warnings to multiple echos
omgitsads Jul 15, 2020
56f6ef5
move to seperate if statement
omgitsads Jul 15, 2020
cab7d91
Change warning to Error when restoring.
omgitsads Jul 15, 2020
ed7d9ae
Don't exit, just warn.
omgitsads Jul 15, 2020
e4c851b
Add notice that we're using logical strategy
omgitsads Jul 15, 2020
0c2f464
Add sentinel file for logical external backups
omgitsads Jul 15, 2020
19954a6
Detect sentinel file on restore and error if not there.
omgitsads Jul 15, 2020
f30c043
add note about ghe-restore-mysql-legacy file
Jul 15, 2020
8e749f3
Merge pull request #173 from github/default-external-database-scripts
Jul 15, 2020
9559370
Add a reminder to restart/reconfigure runners on restore
juliobbv Jul 20, 2020
d0aef7d
Merge pull request #177 from github/runner-warning-message
juliobbv Jul 20, 2020
d0bfbf9
Fail restore if snapshot contains Actions data but Actions is disable…
dhadka Jul 17, 2020
d3b5c14
Fix comment
dhadka Jul 22, 2020
5b60b69
Merge pull request #176 from github/dhadka/warn-actions
dhadka Jul 22, 2020
23e7eb3
Set permissions on actions files before restore
dhadka Jul 22, 2020
0fc9935
Purge parallel so Ubuntu uses moreutils
dhadka Jul 22, 2020
845e2d5
Ensure restore can remove existing content in actions folder
dhadka Jul 22, 2020
4d6e45a
Update .github/workflows/main.yml
dhadka Jul 23, 2020
f5ea799
Fix shellcheck errors
dhadka Jul 23, 2020
3f0a499
Merge branch 'dhadka/actions-permissions' of https://github.com/githu…
dhadka Jul 23, 2020
bb4fab1
Always restore Actions settings
ritchxu Jul 23, 2020
c60f08f
Revert "Always restore Actions settings"
ritchxu Jul 23, 2020
7aa0eca
Always restore Actions settings
ritchxu Jul 23, 2020
4c951f3
Merge pull request #178 from github/dhadka/actions-permissions
dhadka Jul 23, 2020
d6dcb6a
Merge branch 'master' into ritchxu/actions-settings
ritchxu Jul 23, 2020
d96eae9
Merge pull request #179 from github/ritchxu/actions-settings
ritchxu Jul 23, 2020
7d027db
Repair database logins after restore
dhadka Jul 24, 2020
fd13034
Adds fake for ghe-actions-console
dhadka Jul 24, 2020
990b5ef
Merge pull request #181 from github/dhadka/actions-fix-logins
dhadka Jul 29, 2020
d27c682
Update main.yml
dhadka Jul 29, 2020
c5f9e41
Merge pull request #182 from github/dhadka/fix-shellcheck
dhadka Jul 29, 2020
9e0e032
Add launch secrets to backup
cschleiden Jul 31, 2020
e59058e
Merge pull request #183 from github/cschleiden/add-launch-secrets
cschleiden Aug 3, 2020
03b2c22
Merge remote-tracking branch 'upstream/master' into sync-with-public-…
cjonsmith Aug 10, 2020
a2ad32a
Merge remote-tracking branch 'upstream/master' into sync-with-public-…
cjonsmith Aug 11, 2020
58aadea
Merge pull request #184 from github/sync-with-public-repo
cjonsmith Aug 11, 2020
a4fe8f8
added a wait for mysql via haproxy after external restore script
ashishkeshan Aug 17, 2020
dbffdee
added quotes around call to ghe-service-wait-mysql
ashishkeshan Aug 17, 2020
0e54e36
Update share/github-backup-utils/ghe-restore-mysql
ashishkeshan Aug 17, 2020
bb2f1b5
stubbed ghe-service-wait-mysql and fixed typo in other test file
ashishkeshan Aug 17, 2020
087da21
Merge branch 'ashishkeshan/add-wait-for-ha-proxy' of github.com:githu…
ashishkeshan Aug 17, 2020
37426d4
Merge pull request #185 from github/ashishkeshan/add-wait-for-ha-proxy
ashishkeshan Aug 17, 2020
6107410
Merge remote-tracking branch 'upstream/master' into sync-with-public-…
cjonsmith Aug 21, 2020
28cf107
Merge pull request #186 from github/sync-with-public-repo
cjonsmith Aug 21, 2020
2b6fa35
Merge branch 'master' of github.com:github/backup-utils into sync-wit…
cjonsmith Sep 22, 2020
cd619ae
Merge pull request #189 from github/sync-with-public-repo
cjonsmith Sep 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unused test script
  • Loading branch information
@lildude
lildude committed Jan 11, 2018
commit c4793769e03110dc1da641699383f35604f7c7d2
10 changes: 0 additions & 10 deletions test/bin/ghe-config-cluster-values
View file
Open in desktop

This file was deleted.