Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add backup cadence variable to the appliance #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 16, 2021
Merged

Add backup cadence variable to the appliance #719

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
83bba2e
Add backup cadence variable to the appliance
Samirat Apr 9, 2021
dff2d6e
Fix syntax
Samirat Apr 9, 2021
db857c0
Fix again
Samirat Apr 9, 2021
2a85d41
Merge branch 'master' into samirat/add_backup_cadence_to_appliance
Samirat Apr 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions share/github-backup-utils/ghe-backup-mssql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,9 @@ if [ -n "$backup_command" ]; then
ghe-ssh "$GHE_HOSTNAME" -- "$backup_command" || failures="$failures mssql"
bm_end "$(basename $0)"

# Configure the backup cadence on the appliance, which is used for diagnostics
ghe-ssh "$GHE_HOSTNAME" "ghe-config mssql.backup.cadence $GHE_MSSQL_BACKUP_CADENCE"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have to change the script to handle this format.

Copy link
Contributor

@boxofyellow boxofyellow Apr 9, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we consider making our live easier by change this to record the info we need. The hours/days that back should happen.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather have it be the same everywhere and parse it when we use it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.


# Transfer backup files from appliance to backup host
appliance_dir="$GHE_REMOTE_DATA_DIR/user/mssql/backups"
backups=$(echo "set -o pipefail; if sudo test -d \"$appliance_dir\"; then \
Expand Down