Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Allow CustomElements to be redefined #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 30, 2022
Merged

Allow CustomElements to be redefined #197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6e4b571
Use try/catch instead of checking if element is registered
manuelpuyol Apr 4, 2022
113edda
Make sure window is in sync with CustomElements registration
manuelpuyol Apr 4, 2022
4979d09
rethrow errors unless its specifically about redefining
manuelpuyol Apr 25, 2022
bc02a16
change any to unknown
manuelpuyol Apr 25, 2022
93d4035
Merge branch 'main' into allow-hmr-plugins
manuelpuyol Apr 27, 2022
ea5d2b6
Merge branch 'main' into allow-hmr-plugins
keithamus Apr 30, 2022
1b48919
Bump size-limit to 1.6.3kb
keithamus Apr 30, 2022
8b98632
Update size to 1.64kb
keithamus Apr 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
{
"path": "lib/index.js",
"import": "{controller, attr, target, targets}",
"limit": "1.6kb"
"limit": "1.64kb"
}
]
}
13 changes: 10 additions & 3 deletions src/register.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,17 @@ import {dasherize} from './dasherize.js'
*/
export function register(classObject: CustomElement): void {
const name = dasherize(classObject.name).replace(/-element$/, '')
if (!window.customElements.get(name)) {

try {
window.customElements.define(name, classObject)
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
window[classObject.name] = classObject
window.customElements.define(name, classObject)
window[classObject.name] = customElements.get(name)
} catch (e: unknown) {
// The only reason for window.customElements.define to throw a `NotSupportedError`
// is if the element has already been defined.
if (e instanceof DOMException && e.name === 'NotSupportedError') return

throw e
}
}