Update TimingAttack.qll

ahmed-farid-dev · web-flow · commit 005839b46231 · 2023-02-16T12:49:40.000+01:00
diff --git a/python/ql/src/experimental/semmle/python/security/TimingAttack.qll b/python/ql/src/experimental/semmle/python/security/TimingAttack.qll
@@ -146,10 +146,12 @@ private predicate existsFailFastCheck(Expr firstInput, Expr secondInput) {
     ) and
     (
       compare.getLeft() = firstInput and
-      compare.getComparator(0) = secondInput
+      compare.getComparator(0) = secondInput and
+      not compare.getAComparator() instanceof None
       or
       compare.getLeft() = secondInput and
-      compare.getComparator(0) = firstInput
+      compare.getComparator(0) = firstInput and
+      not compare.getAComparator() instanceof None
     )
   )
 }

Original file line number	Diff line number	Diff line change
`@@ -146,10 +146,12 @@ private predicate existsFailFastCheck(Expr firstInput, Expr secondInput) {`
`146`	`146`	`) and`
`147`	`147`	`(`
`148`	`148`	`compare.getLeft() = firstInput and`
`149`		`- compare.getComparator(0) = secondInput`
	`149`	`+ compare.getComparator(0) = secondInput and`
	`150`	`+ not compare.getAComparator() instanceof None`
`150`	`151`	`or`
`151`	`152`	`compare.getLeft() = secondInput and`
`152`		`- compare.getComparator(0) = firstInput`
	`153`	`+ compare.getComparator(0) = firstInput and`
	`154`	`+ not compare.getAComparator() instanceof None`
`153`	`155`	`)`
`154`	`156`	`)`
`155`	`157`	`}`