C++: make internal classes private

Robert Marsh · Robert Marsh · commit 0273b20743ab · 2018-09-20T10:06:17.000-07:00
diff --git a/cpp/ql/src/semmle/code/cpp/controlflow/IRGuards.qll b/cpp/ql/src/semmle/code/cpp/controlflow/IRGuards.qll
@@ -63,7 +63,7 @@ class GuardCondition extends Expr {
   abstract cached predicate ensuresEq(Expr left, Expr right, int k, BasicBlock block, boolean areEqual);
 }
 
-class GuardConditionFromBinaryLogicalOperator extends GuardCondition {
+private class GuardConditionFromBinaryLogicalOperator extends GuardCondition {
   GuardConditionFromBinaryLogicalOperator() {
     exists(GuardCondition gc |
       this.(BinaryLogicalOperation).getAnOperand()= gc
@@ -106,7 +106,7 @@ class GuardConditionFromBinaryLogicalOperator extends GuardCondition {
   }
 }
 
-class GuardConditionFromShortCircuitNot extends GuardCondition, NotExpr {
+private class GuardConditionFromShortCircuitNot extends GuardCondition, NotExpr {
   GuardConditionFromShortCircuitNot() {
     not exists (Instruction inst | this.getFullyConverted() = inst.getAST()) and
     exists(IRGuardCondition ir | getOperand() = ir.getAST())
@@ -133,7 +133,7 @@ class GuardConditionFromShortCircuitNot extends GuardCondition, NotExpr {
   }
 }
 
-class GuardConditionFromIR extends GuardCondition {
+private class GuardConditionFromIR extends GuardCondition {
   IRGuardCondition ir;
   
   GuardConditionFromIR() {

Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@ class GuardCondition extends Expr {`
`63`	`63`	`abstract cached predicate ensuresEq(Expr left, Expr right, int k, BasicBlock block, boolean areEqual);`
`64`	`64`	`}`
`65`	`65`
`66`		`-class GuardConditionFromBinaryLogicalOperator extends GuardCondition {`
	`66`	`+private class GuardConditionFromBinaryLogicalOperator extends GuardCondition {`
`67`	`67`	`GuardConditionFromBinaryLogicalOperator() {`
`68`	`68`	`exists(GuardCondition gc \|`
`69`	`69`	`this.(BinaryLogicalOperation).getAnOperand()= gc`
`@@ -106,7 +106,7 @@ class GuardConditionFromBinaryLogicalOperator extends GuardCondition {`
`106`	`106`	`}`
`107`	`107`	`}`
`108`	`108`
`109`		`-class GuardConditionFromShortCircuitNot extends GuardCondition, NotExpr {`
	`109`	`+private class GuardConditionFromShortCircuitNot extends GuardCondition, NotExpr {`
`110`	`110`	`GuardConditionFromShortCircuitNot() {`
`111`	`111`	`not exists (Instruction inst \| this.getFullyConverted() = inst.getAST()) and`
`112`	`112`	`exists(IRGuardCondition ir \| getOperand() = ir.getAST())`
`@@ -133,7 +133,7 @@ class GuardConditionFromShortCircuitNot extends GuardCondition, NotExpr {`
`133`	`133`	`}`
`134`	`134`	`}`
`135`	`135`
`136`		`-class GuardConditionFromIR extends GuardCondition {`
	`136`	`+private class GuardConditionFromIR extends GuardCondition {`
`137`	`137`	`IRGuardCondition ir;`
`138`	`138`
`139`	`139`	`GuardConditionFromIR() {`