Data flow: Fix bad join-orders in summaryNodeType

hvitved · hvitved · commit 09daf86e33bb · 2021-07-12T12:09:06.000+02:00
diff --git a/csharp/ql/src/semmle/code/csharp/dataflow/internal/FlowSummaryImpl.qll b/csharp/ql/src/semmle/code/csharp/dataflow/internal/FlowSummaryImpl.qll
@@ -375,7 +375,9 @@ module Private {
         or
         exists(ReturnKind rk |
           head = TReturnSummaryComponent(rk) and
-          result = getCallbackReturnType(getNodeType(summaryNodeInputState(c, s.drop(1))), rk)
+          result =
+            getCallbackReturnType(getNodeType(summaryNodeInputState(pragma[only_bind_out](c),
+                  s.drop(1))), rk)
         )
       )
       or
@@ -392,7 +394,9 @@ module Private {
         )
         or
         exists(int i | head = TParameterSummaryComponent(i) |
-          result = getCallbackParameterType(getNodeType(summaryNodeOutputState(c, s.drop(1))), i)
+          result =
+            getCallbackParameterType(getNodeType(summaryNodeOutputState(pragma[only_bind_out](c),
+                  s.drop(1))), i)
         )
       )
     )

Original file line number	Diff line number	Diff line change
`@@ -375,7 +375,9 @@ module Private {`
`375`	`375`	`or`
`376`	`376`	`exists(ReturnKind rk \|`
`377`	`377`	`head = TReturnSummaryComponent(rk) and`
`378`		`- result = getCallbackReturnType(getNodeType(summaryNodeInputState(c, s.drop(1))), rk)`
	`378`	`+ result =`
	`379`	`+ getCallbackReturnType(getNodeType(summaryNodeInputState(pragma[only_bind_out](c),`
	`380`	`+ s.drop(1))), rk)`
`379`	`381`	`)`
`380`	`382`	`)`
`381`	`383`	`or`
`@@ -392,7 +394,9 @@ module Private {`
`392`	`394`	`)`
`393`	`395`	`or`
`394`	`396`	`exists(int i \| head = TParameterSummaryComponent(i) \|`
`395`		`- result = getCallbackParameterType(getNodeType(summaryNodeOutputState(c, s.drop(1))), i)`
	`397`	`+ result =`
	`398`	`+ getCallbackParameterType(getNodeType(summaryNodeOutputState(pragma[only_bind_out](c),`
	`399`	`+ s.drop(1))), i)`
`396`	`400`	`)`
`397`	`401`	`)`
`398`	`402`	`)`