Python: Fix ModuleVariableNode.toString

RasmusWL · RasmusWL · commit 0c4bcec39e4f · 2023-04-26T16:03:21.000+02:00
In some cases mod.getName() does not have a result, so toString of
ModuleVariableNode would also not have a result, which would cause
data-flow paths that use these as an edge to not be valid :O
diff --git a/python/ql/lib/semmle/python/dataflow/new/internal/DataFlowPublic.qll b/python/ql/lib/semmle/python/dataflow/new/internal/DataFlowPublic.qll
@@ -407,7 +407,7 @@ class ModuleVariableNode extends Node, TModuleVariableNode {
   override Scope getScope() { result = mod }
 
   override string toString() {
-    result = "ModuleVariableNode for " + mod.getName() + "." + var.getId()
+    result = "ModuleVariableNode in " + mod.toString() + " for " + var.getId()
   }
 
   /** Gets the module in which this variable appears. */

Original file line number	Diff line number	Diff line change
`@@ -407,7 +407,7 @@ class ModuleVariableNode extends Node, TModuleVariableNode {`
`407`	`407`	`override Scope getScope() { result = mod }`
`408`	`408`
`409`	`409`	`override string toString() {`
`410`		`- result = "ModuleVariableNode for " + mod.getName() + "." + var.getId()`
	`410`	`+ result = "ModuleVariableNode in " + mod.toString() + " for " + var.getId()`
`411`	`411`	`}`
`412`	`412`
`413`	`413`	`/** Gets the module in which this variable appears. */`