Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 23da0c1

Browse files
geoffw0geoffw0
committed
C++: Add more test cases for indirection (3).
1 parent 7c4927c commit 23da0c1

3 files changed

Lines changed: 37 additions & 23 deletions

File tree

‎cpp/ql/test/library-tests/dataflow/models-as-data/FlowSummaryNode.expected‎

Lines changed: 23 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,23 @@
1-
| tests.cpp:120:5:120:19 | [summary param] 0 in madArg0ToReturn | ParameterNode | madArg0ToReturn | madArg0ToReturn |
2-
| tests.cpp:120:5:120:19 | [summary] to write: ReturnValue in madArg0ToReturn | ReturnNode | madArg0ToReturn | madArg0ToReturn |
3-
| tests.cpp:123:5:123:28 | [summary param] 0 in madArg0ToReturnValueFlow | ParameterNode | madArg0ToReturnValueFlow | madArg0ToReturnValueFlow |
4-
| tests.cpp:123:5:123:28 | [summary] to write: ReturnValue in madArg0ToReturnValueFlow | ReturnNode | madArg0ToReturnValueFlow | madArg0ToReturnValueFlow |
5-
| tests.cpp:198:7:198:19 | [summary param] 0 in madArg0ToSelf | ParameterNode | madArg0ToSelf | madArg0ToSelf |
6-
| tests.cpp:198:7:198:19 | [summary param] this indirection in madArg0ToSelf | ParameterNode | madArg0ToSelf | madArg0ToSelf |
7-
| tests.cpp:198:7:198:19 | [summary] to write: Argument[this indirection] in madArg0ToSelf | PostUpdateNode | madArg0ToSelf | madArg0ToSelf |
8-
| tests.cpp:199:6:199:20 | [summary param] this indirection in madSelfToReturn | ParameterNode | madSelfToReturn | madSelfToReturn |
9-
| tests.cpp:199:6:199:20 | [summary] to write: ReturnValue in madSelfToReturn | ReturnNode | madSelfToReturn | madSelfToReturn |
10-
| tests.cpp:227:7:227:30 | [summary param] this indirection in namespaceMadSelfToReturn | ParameterNode | namespaceMadSelfToReturn | namespaceMadSelfToReturn |
11-
| tests.cpp:227:7:227:30 | [summary] to write: ReturnValue in namespaceMadSelfToReturn | ReturnNode | namespaceMadSelfToReturn | namespaceMadSelfToReturn |
12-
| tests.cpp:338:5:338:29 | [summary param] 0 in madCallArg0ReturnToReturn | ParameterNode | madCallArg0ReturnToReturn | madCallArg0ReturnToReturn |
13-
| tests.cpp:338:5:338:29 | [summary] read: Argument[0].Parameter[this] in madCallArg0ReturnToReturn | PostUpdateNode | madCallArg0ReturnToReturn | madCallArg0ReturnToReturn |
14-
| tests.cpp:338:5:338:29 | [summary] read: Argument[0].ReturnValue in madCallArg0ReturnToReturn | OutNode | madCallArg0ReturnToReturn | madCallArg0ReturnToReturn |
15-
| tests.cpp:338:5:338:29 | [summary] to write: Argument[0].Parameter[this] in madCallArg0ReturnToReturn | ArgumentNode | madCallArg0ReturnToReturn | madCallArg0ReturnToReturn |
16-
| tests.cpp:338:5:338:29 | [summary] to write: ReturnValue in madCallArg0ReturnToReturn | ReturnNode | madCallArg0ReturnToReturn | madCallArg0ReturnToReturn |
17-
| tests.cpp:340:6:340:25 | [summary param] 0 in madCallArg0WithValue | ParameterNode | madCallArg0WithValue | madCallArg0WithValue |
18-
| tests.cpp:340:6:340:25 | [summary param] 1 in madCallArg0WithValue | ParameterNode | madCallArg0WithValue | madCallArg0WithValue |
19-
| tests.cpp:340:6:340:25 | [summary] read: Argument[0].Parameter[0] in madCallArg0WithValue | PostUpdateNode | madCallArg0WithValue | madCallArg0WithValue |
20-
| tests.cpp:340:6:340:25 | [summary] read: Argument[0].Parameter[this] in madCallArg0WithValue | PostUpdateNode | madCallArg0WithValue | madCallArg0WithValue |
21-
| tests.cpp:340:6:340:25 | [summary] to write: Argument[0].Parameter[0] in madCallArg0WithValue | ArgumentNode | madCallArg0WithValue | madCallArg0WithValue |
22-
| tests.cpp:340:6:340:25 | [summary] to write: Argument[0].Parameter[this] in madCallArg0WithValue | ArgumentNode | madCallArg0WithValue | madCallArg0WithValue |
23-
| tests.cpp:340:6:340:25 | [summary] to write: Argument[1] in madCallArg0WithValue | PostUpdateNode | madCallArg0WithValue | madCallArg0WithValue |
1+
| tests.cpp:126:5:126:19 | [summary param] 0 in madArg0ToReturn | ParameterNode | madArg0ToReturn | madArg0ToReturn |
2+
| tests.cpp:126:5:126:19 | [summary] to write: ReturnValue in madArg0ToReturn | ReturnNode | madArg0ToReturn | madArg0ToReturn |
3+
| tests.cpp:129:5:129:28 | [summary param] 0 in madArg0ToReturnValueFlow | ParameterNode | madArg0ToReturnValueFlow | madArg0ToReturnValueFlow |
4+
| tests.cpp:129:5:129:28 | [summary] to write: ReturnValue in madArg0ToReturnValueFlow | ReturnNode | madArg0ToReturnValueFlow | madArg0ToReturnValueFlow |
5+
| tests.cpp:209:7:209:19 | [summary param] 0 in madArg0ToSelf | ParameterNode | madArg0ToSelf | madArg0ToSelf |
6+
| tests.cpp:209:7:209:19 | [summary param] this indirection in madArg0ToSelf | ParameterNode | madArg0ToSelf | madArg0ToSelf |
7+
| tests.cpp:209:7:209:19 | [summary] to write: Argument[this indirection] in madArg0ToSelf | PostUpdateNode | madArg0ToSelf | madArg0ToSelf |
8+
| tests.cpp:210:6:210:20 | [summary param] this indirection in madSelfToReturn | ParameterNode | madSelfToReturn | madSelfToReturn |
9+
| tests.cpp:210:6:210:20 | [summary] to write: ReturnValue in madSelfToReturn | ReturnNode | madSelfToReturn | madSelfToReturn |
10+
| tests.cpp:238:7:238:30 | [summary param] this indirection in namespaceMadSelfToReturn | ParameterNode | namespaceMadSelfToReturn | namespaceMadSelfToReturn |
11+
| tests.cpp:238:7:238:30 | [summary] to write: ReturnValue in namespaceMadSelfToReturn | ReturnNode | namespaceMadSelfToReturn | namespaceMadSelfToReturn |
12+
| tests.cpp:349:5:349:29 | [summary param] 0 in madCallArg0ReturnToReturn | ParameterNode | madCallArg0ReturnToReturn | madCallArg0ReturnToReturn |
13+
| tests.cpp:349:5:349:29 | [summary] read: Argument[0].Parameter[this] in madCallArg0ReturnToReturn | PostUpdateNode | madCallArg0ReturnToReturn | madCallArg0ReturnToReturn |
14+
| tests.cpp:349:5:349:29 | [summary] read: Argument[0].ReturnValue in madCallArg0ReturnToReturn | OutNode | madCallArg0ReturnToReturn | madCallArg0ReturnToReturn |
15+
| tests.cpp:349:5:349:29 | [summary] to write: Argument[0].Parameter[this] in madCallArg0ReturnToReturn | ArgumentNode | madCallArg0ReturnToReturn | madCallArg0ReturnToReturn |
16+
| tests.cpp:349:5:349:29 | [summary] to write: ReturnValue in madCallArg0ReturnToReturn | ReturnNode | madCallArg0ReturnToReturn | madCallArg0ReturnToReturn |
17+
| tests.cpp:351:6:351:25 | [summary param] 0 in madCallArg0WithValue | ParameterNode | madCallArg0WithValue | madCallArg0WithValue |
18+
| tests.cpp:351:6:351:25 | [summary param] 1 in madCallArg0WithValue | ParameterNode | madCallArg0WithValue | madCallArg0WithValue |
19+
| tests.cpp:351:6:351:25 | [summary] read: Argument[0].Parameter[0] in madCallArg0WithValue | PostUpdateNode | madCallArg0WithValue | madCallArg0WithValue |
20+
| tests.cpp:351:6:351:25 | [summary] read: Argument[0].Parameter[this] in madCallArg0WithValue | PostUpdateNode | madCallArg0WithValue | madCallArg0WithValue |
21+
| tests.cpp:351:6:351:25 | [summary] to write: Argument[0].Parameter[0] in madCallArg0WithValue | ArgumentNode | madCallArg0WithValue | madCallArg0WithValue |
22+
| tests.cpp:351:6:351:25 | [summary] to write: Argument[0].Parameter[this] in madCallArg0WithValue | ArgumentNode | madCallArg0WithValue | madCallArg0WithValue |
23+
| tests.cpp:351:6:351:25 | [summary] to write: Argument[1] in madCallArg0WithValue | PostUpdateNode | madCallArg0WithValue | madCallArg0WithValue |

‎cpp/ql/test/library-tests/dataflow/models-as-data/testModels.qll‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ private class TestSources extends SourceModelCsv {
1212
";;false;localMadSourceVoid;;;ReturnValue;local",
1313
";;false;localMadSourceHasBody;;;ReturnValue;local",
1414
";;false;remoteMadSourceIndirect;;;*ReturnValue;remote",
15+
";;false;remoteMadSourceDoubleIndirect;;;**ReturnValue;remote",
1516
";;false;remoteMadSourceIndirectArg0;;;*Argument[0];remote",
1617
";;false;remoteMadSourceIndirectArg1;;;*Argument[1];remote",
1718
";;false;remoteMadSourceVar;;;;remote",
@@ -43,6 +44,7 @@ private class TestSinks extends SinkModelCsv {
4344
";;false;madSinkArg01;;;Argument[0..1];test-sink",
4445
";;false;madSinkArg02;;;Argument[0,2];test-sink",
4546
";;false;madSinkIndirectArg0;;;*Argument[0];test-sink",
47+
";;false;madSinkDoubleIndirectArg0;;;**Argument[0];test-sink",
4648
";;false;madSinkVar;;;;test-sink",
4749
";;false;madSinkVarIndirect;;;*;test-sink",
4850
";;false;madSinkParam0;;;Parameter[0];test-sink",
@@ -69,6 +71,7 @@ private class TestSummaries extends SummaryModelCsv {
6971
";;false;madArg0ToReturnIndirect;;;Argument[0];*ReturnValue;taint",
7072
";;false;madArg0ToReturnValueFlow;;;Argument[0];ReturnValue;value",
7173
";;false;madArg0IndirectToReturn;;;*Argument[0];ReturnValue;taint",
74+
";;false;madArg0DoubleIndirectToReturn;;;**Argument[0];ReturnValue;taint",
7275
";;false;madArg0ToArg1Indirect;;;Argument[0];*Argument[1];taint",
7376
";;false;madArg0IndirectToArg1Indirect;;;*Argument[0];*Argument[1];taint",
7477
";;false;madArg0FieldToReturn;;;Argument[0].value;ReturnValue;taint",

‎cpp/ql/test/library-tests/dataflow/models-as-data/tests.cpp‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ int notASource();
1111
int localMadSourceVoid(void); // $ interpretElement
1212
int localMadSourceHasBody() { return 0; } // $ interpretElement
1313
int *remoteMadSourceIndirect(); // $ interpretElement
14+
int **remoteMadSourceDoubleIndirect(); // $ interpretElement
1415
void remoteMadSourceIndirectArg0(int *x, int *y); // $ interpretElement
1516
void remoteMadSourceIndirectArg1(int &x, int &y); // $ interpretElement
1617
int remoteMadSourceVar; // $ interpretElement
@@ -40,6 +41,7 @@ void test_sources() {
4041
sink(localMadSourceVoid()); // $ ir
4142
sink(localMadSourceHasBody()); // $ ir
4243
sink(*remoteMadSourceIndirect()); // $ MISSING: ir
44+
sink(**remoteMadSourceDoubleIndirect()); // $ MISSING: ir
4345

4446
int a, b, c, d;
4547

@@ -76,6 +78,7 @@ void madSinkArg1(int x, int y); // $ interpretElement
7678
void madSinkArg01(int x, int y, int z); // $ interpretElement
7779
void madSinkArg02(int x, int y, int z); // $ interpretElement
7880
void madSinkIndirectArg0(int *x); // $ interpretElement
81+
void madSinkDoubleIndirectArg0(int **x); // $ interpretElement
7982
int madSinkVar; // $ interpretElement
8083
int *madSinkVarIndirect; // $ interpretElement
8184

@@ -94,7 +97,10 @@ void test_sinks() {
9497
madSinkArg02(0, 0, source()); // $ ir
9598

9699
int a = source();
100+
int *a_ptr = &a;
97101
madSinkIndirectArg0(&a); // $ MISSING: ir
102+
madSinkIndirectArg0(a_ptr); // $ MISSING: ir
103+
madSinkDoubleIndirectArg0(&a_ptr); // $ MISSING: ir
98104

99105
madSinkVar = source(); // $ ir
100106

@@ -122,6 +128,7 @@ int *madArg0ToReturnIndirect(int x); // $ interpretElement
122128
int notASummary(int x);
123129
int madArg0ToReturnValueFlow(int x); // $ interpretElement
124130
int madArg0IndirectToReturn(int *x); // $ interpretElement
131+
int madArg0DoubleIndirectToReturn(int **x); // $ interpretElement
125132
void madArg0ToArg1Indirect(int x, int &y); // $ interpretElement
126133
void madArg0IndirectToArg1Indirect(const int *x, int *y); // $ interpretElement
127134

@@ -134,6 +141,7 @@ void test_summaries() {
134141
// test summaries
135142

136143
int a, b, c, d, e;
144+
int *a_ptr;
137145

138146
sink(madArg0ToReturn(0));
139147
sink(madArg0ToReturn(source())); // $ ir
@@ -144,7 +152,10 @@ void test_summaries() {
144152
sink(madArg0ToReturnValueFlow(source())); // $ ir
145153

146154
a = source();
155+
a_ptr = &a;
147156
sink(madArg0IndirectToReturn(&a)); // $ MISSING: ir
157+
sink(madArg0IndirectToReturn(a_ptr)); // $ MISSING: ir
158+
sink(madArg0DoubleIndirectToReturn(&a_ptr)); // $ MISSING: ir
148159

149160
madArg0ToArg1Indirect(source(), b);
150161
sink(b); // $ MISSING: ir

0 commit comments

Comments
 (0)