C++: Add models-as-data case to allowParameterReturnInSelf.

geoffw0 · geoffw0 · commit 23fd3f62ac25 · 2024-03-06T16:12:46.000Z
diff --git a/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowPrivate.qll b/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowPrivate.qll
@@ -1280,7 +1280,12 @@ predicate additionalLambdaFlowStep(Node nodeFrom, Node nodeTo, boolean preserves
  */
 predicate allowParameterReturnInSelf(ParameterNode p) {
   p instanceof IndirectParameterNode
-  // TODO: Swift has a case for summarized callables here.
+  or
+  // models-as-data summarized flow
+  exists(DataFlowCallable c, ParameterPosition pos |
+    p.(ParameterNode).isParameterOf(c, pos) and
+    FlowSummaryImpl::Private::summaryAllowParameterReturnInSelf(c.asSummarizedCallable(), pos)
+  )
 }
 
 private predicate fieldHasApproxName(Field f, string s) {
