Remove unnecessary type constraint

smowton · web-flow · commit 24e3ad4e180f · 2021-09-22T10:54:24.000+01:00
diff --git a/java/ql/src/experimental/semmle/code/java/Logging.qll b/java/ql/src/experimental/semmle/code/java/Logging.qll
@@ -31,7 +31,6 @@ class LoggingCall extends MethodAccess {
     exists(RefType t, Method m | t.hasQualifiedName("android.util", "Log") |
       m.hasName(["d", "e", "i", "v", "w", "wtf"]) and
       m.getDeclaringType() = t and
-      m.getReturnType() instanceof IntegralType and
       this = m.getAReference()
     )
   }

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,6 @@ class LoggingCall extends MethodAccess {`
`31`	`31`	`exists(RefType t, Method m \| t.hasQualifiedName("android.util", "Log") \|`
`32`	`32`	`m.hasName(["d", "e", "i", "v", "w", "wtf"]) and`
`33`	`33`	`m.getDeclaringType() = t and`
`34`		`- m.getReturnType() instanceof IntegralType and`
`35`	`34`	`this = m.getAReference()`
`36`	`35`	`)`
`37`	`36`	`}`