CPP: Add a test of ReturnStackAllocatedMemory.

geoffw0 · geoffw0 · commit 25e11512db46 · 2019-01-30T18:36:31.000Z
diff --git a/cpp/ql/test/query-tests/Likely Bugs/Memory Management/ReturnStackAllocatedMemory/ReturnCstrOfLocalStdString.expected b/cpp/ql/test/query-tests/Likely Bugs/Memory Management/ReturnStackAllocatedMemory/ReturnCstrOfLocalStdString.expected
@@ -0,0 +1 @@
+| test.cpp:93:2:93:12 | return ... | May return stack-allocated memory. |
diff --git a/cpp/ql/test/query-tests/Likely Bugs/Memory Management/ReturnStackAllocatedMemory/ReturnCstrOfLocalStdString.qlref b/cpp/ql/test/query-tests/Likely Bugs/Memory Management/ReturnStackAllocatedMemory/ReturnCstrOfLocalStdString.qlref
@@ -0,0 +1 @@
+Likely Bugs/Memory Management/ReturnStackAllocatedMemory.ql
diff --git a/cpp/ql/test/query-tests/Likely Bugs/Memory Management/ReturnStackAllocatedMemory/test.cpp b/cpp/ql/test/query-tests/Likely Bugs/Memory Management/ReturnStackAllocatedMemory/test.cpp
@@ -0,0 +1,126 @@
+
+class MyClass
+{
+public:
+	int a, b;
+};
+
+MyClass *test1()
+{
+	MyClass mc;
+
+	return &mc; // BAD [NOT DETECTED]
+}
+
+MyClass *test2()
+{
+	MyClass mc;
+	MyClass *ptr = &mc;
+
+	return ptr; // BAD [NOT DETECTED]
+}
+
+MyClass *test3()
+{
+	MyClass mc;
+	MyClass &ref = mc;
+
+	return &ref; // BAD [NOT DETECTED]
+}
+
+int *test4()
+{
+	MyClass mc;
+
+	return &(mc.a); // BAD [NOT DETECTED]
+}
+
+MyClass test6()
+{
+	MyClass mc;
+
+	return mc; // GOOD
+}
+
+MyClass *test7()
+{
+	MyClass *mc = new MyClass;
+
+	return mc; // GOOD
+}
+
+MyClass test8()
+{
+	return MyClass(); // GOOD
+}
+
+int test9()
+{
+	MyClass mc;
+
+	return mc.a; // GOOD
+}
+
+MyClass *test10()
+{
+	MyClass *ptr;
+
+	{
+		MyClass mc;
+		ptr = &mc;
+	}
+
+	return ptr; // BAD [NOT DETECTED]
+}
+
+MyClass *test11(MyClass *param)
+{
+	return param; // GOOD
+}
+
+MyClass *test12()
+{
+	static MyClass mc;
+	MyClass &ref = mc;
+
+	return &ref; // GOOD
+}
+
+char *testArray1()
+{
+	char arr[256];
+
+	return arr; // BAD
+}
+
+char *testArray2()
+{
+	char arr[256];
+
+	return &(arr[10]); // BAD [NOT DETECTED]
+}
+
+char testArray3()
+{
+	char arr[256];
+
+	return arr[10]; // GOOD
+}
+
+char *testArray4()
+{
+	char arr[256];
+	char *ptr;
+
+	ptr = arr + 1;
+	ptr++;
+
+	return ptr; // BAD [NOT DETECTED]
+}
+
+char *testArray5()
+{
+	static char arr[256];
+
+	return arr; // GOOD
+}

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+\| test.cpp:93:2:93:12 \| return ... \| May return stack-allocated memory. \|`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Likely Bugs/Memory Management/ReturnStackAllocatedMemory.ql`