Autoformat, address review.

criemen · criemen · commit 264763080e8c · 2020-05-05T08:52:52.000+02:00
diff --git a/cpp/ql/src/experimental/semmle/code/cpp/rangeanalysis/ArrayLengthAnalysis.qll b/cpp/ql/src/experimental/semmle/code/cpp/rangeanalysis/ArrayLengthAnalysis.qll
@@ -124,7 +124,7 @@ private int getBaseSizeForPointerType(PointerType type) { result = type.getBaseT
  * steps to `array` that points to `offset + offsetDelta` in one step.
  * This predicate does not contain any recursive steps.
  */
-bindingset[prevOffset,prevOffsetDelta]
+bindingset[prevOffset, prevOffsetDelta]
 predicate simpleArrayLengthStep(
   Instruction array, Offset offset, int offsetDelta, Instruction prev, Offset prevOffset,
   int prevOffsetDelta
diff --git a/cpp/ql/src/semmle/code/cpp/rangeanalysis/RangeUtils.qll b/cpp/ql/src/semmle/code/cpp/rangeanalysis/RangeUtils.qll
@@ -104,17 +104,28 @@ private predicate safeCast(IntegralType fromtyp, IntegralType totyp) {
   )
 }
 
+/**
+ * A `ConvertInstruction` which casts from one pointer type to another.
+ */
 class PtrToPtrCastInstruction extends ConvertInstruction {
   PtrToPtrCastInstruction() {
     getResultType() instanceof PointerType and
     getUnary().getResultType() instanceof PointerType
   }
 }
 
+/**
+ * A `ConvertInstruction` which casts from one integer type to another in a way
+ * that cannot overflow or underflow.
+ */
 class SafeIntCastInstruction extends ConvertInstruction {
   SafeIntCastInstruction() { safeCast(getUnary().getResultType(), getResultType()) }
 }
 
+/**
+ * A `ConvertInstruction` which does not invalidate bounds determined by
+ * range analysis.
+ */
 class SafeCastInstruction extends ConvertInstruction {
   SafeCastInstruction() {
     this instanceof PtrToPtrCastInstruction or

Original file line number	Diff line number	Diff line change
`@@ -104,17 +104,28 @@ private predicate safeCast(IntegralType fromtyp, IntegralType totyp) {`
`104`	`104`	`)`
`105`	`105`	`}`
`106`	`106`
	`107`	`+/**`
	`108`	+ * A `ConvertInstruction` which casts from one pointer type to another.
	`109`	`+ */`
`107`	`110`	`class PtrToPtrCastInstruction extends ConvertInstruction {`
`108`	`111`	`PtrToPtrCastInstruction() {`
`109`	`112`	`getResultType() instanceof PointerType and`
`110`	`113`	`getUnary().getResultType() instanceof PointerType`
`111`	`114`	`}`
`112`	`115`	`}`
`113`	`116`
	`117`	`+/**`
	`118`	+ * A `ConvertInstruction` which casts from one integer type to another in a way
	`119`	`+ * that cannot overflow or underflow.`
	`120`	`+ */`
`114`	`121`	`class SafeIntCastInstruction extends ConvertInstruction {`
`115`	`122`	`SafeIntCastInstruction() { safeCast(getUnary().getResultType(), getResultType()) }`
`116`	`123`	`}`
`117`	`124`
	`125`	`+/**`
	`126`	+ * A `ConvertInstruction` which does not invalidate bounds determined by
	`127`	`+ * range analysis.`
	`128`	`+ */`
`118`	`129`	`class SafeCastInstruction extends ConvertInstruction {`
`119`	`130`	`SafeCastInstruction() {`
`120`	`131`	`this instanceof PtrToPtrCastInstruction or`