Fix test comments

atorralba · atorralba · commit 2c4246f29a20 · 2023-04-26T10:08:18.000+02:00
diff --git a/java/ql/test/library-tests/dataflow/taint/StringJoinerTests.java b/java/ql/test/library-tests/dataflow/taint/StringJoinerTests.java
@@ -10,77 +10,77 @@ void sink(Object o) {}
 
 	public void test() throws Exception {
 		{
-			// "java.util;StringJoiner;true;StringJoiner;(CharSequence);;Argument[0];Argument[-1];taint;manual"
+			// "java.util;StringJoiner;false;StringJoiner;(CharSequence);;Argument[0];Argument[-1];taint;manual"
 			StringJoiner out = null;
 			CharSequence in = (CharSequence) taint();
 			out = new StringJoiner(in);
 			sink(out);
 		}
 		{
-			// "java.util;StringJoiner;true;StringJoiner;(CharSequence,CharSequence,CharSequence);;Argument[0];Argument[-1];taint;manual"
+			// "java.util;StringJoiner;false;StringJoiner;(CharSequence,CharSequence,CharSequence);;Argument[0];Argument[-1];taint;manual"
 			StringJoiner out = null;
 			CharSequence in = (CharSequence) taint();
 			out = new StringJoiner(in, null, null);
 			sink(out);
 		}
 		{
-			// "java.util;StringJoiner;true;StringJoiner;(CharSequence,CharSequence,CharSequence);;Argument[1];Argument[-1];taint;manual"
+			// "java.util;StringJoiner;false;StringJoiner;(CharSequence,CharSequence,CharSequence);;Argument[1];Argument[-1];taint;manual"
 			StringJoiner out = null;
 			CharSequence in = (CharSequence) taint();
 			out = new StringJoiner(null, in, null);
 			sink(out);
 		}
 		{
-			// "java.util;StringJoiner;true;StringJoiner;(CharSequence,CharSequence,CharSequence);;Argument[2];Argument[-1];taint;manual"
+			// "java.util;StringJoiner;false;StringJoiner;(CharSequence,CharSequence,CharSequence);;Argument[2];Argument[-1];taint;manual"
 			StringJoiner out = null;
 			CharSequence in = (CharSequence) taint();
 			out = new StringJoiner(null, null, in);
 			sink(out);
 		}
 		{
-			// "java.util;StringJoiner;true;add;;;Argument[-1];ReturnValue;value;manual"
+			// "java.util;StringJoiner;false;add;;;Argument[-1];ReturnValue;value;manual"
 			StringJoiner out = null;
 			StringJoiner in = (StringJoiner) taint();
 			out = in.add(null);
 			sink(out);
 		}
 		{
-			// "java.util;StringJoiner;true;add;;;Argument[0];Argument[-1];taint;manual"
+			// "java.util;StringJoiner;false;add;;;Argument[0];Argument[-1];taint;manual"
 			StringJoiner out = null;
 			CharSequence in = (CharSequence) taint();
 			out.add(in);
 			sink(out);
 		}
 		{
-			// "java.util;StringJoiner;true;merge;;;Argument[-1];ReturnValue;value;manual"
+			// "java.util;StringJoiner;false;merge;;;Argument[-1];ReturnValue;value;manual"
 			StringJoiner out = null;
 			StringJoiner in = (StringJoiner) taint();
 			out = in.merge(null);
 			sink(out);
 		}
 		{
-			// "java.util;StringJoiner;true;merge;;;Argument[0];Argument[-1];taint;manual"
+			// "java.util;StringJoiner;false;merge;;;Argument[0];Argument[-1];taint;manual"
 			StringJoiner out = null;
 			StringJoiner in = (StringJoiner) taint();
 			out.merge(in);
 			sink(out);
 		}
 		{
-			// "java.util;StringJoiner;true;setEmptyValue;;;Argument[-1];ReturnValue;taint;manual"
+			// "java.util;StringJoiner;false;setEmptyValue;;;Argument[-1];ReturnValue;taint;manual"
 			StringJoiner out = null;
 			StringJoiner in = (StringJoiner) taint();
 			out = in.setEmptyValue(null);
 			sink(out);
 		}
 		{
-			// "java.util;StringJoiner;true;setEmptyValue;;;Argument[0];Argument[-1];taint;manual"
+			// "java.util;StringJoiner;false;setEmptyValue;;;Argument[0];Argument[-1];taint;manual"
 			StringJoiner out = null;
 			CharSequence in = (CharSequence) taint();
 			out.setEmptyValue(in);
 			sink(out);
 		}
 		{
-			// "java.util;StringJoiner;true;toString;;;Argument[-1];ReturnValue;taint;manual"
+			// "java.util;StringJoiner;false;toString;;;Argument[-1];ReturnValue;taint;manual"
 			String out = null;
 			StringJoiner in = (StringJoiner) taint();
 			out = in.toString();

Original file line number	Diff line number	Diff line change
`@@ -10,77 +10,77 @@ void sink(Object o) {}`
`10`	`10`
`11`	`11`	`public void test() throws Exception {`
`12`	`12`	`{`
`13`		`- // "java.util;StringJoiner;true;StringJoiner;(CharSequence);;Argument[0];Argument[-1];taint;manual"`
	`13`	`+ // "java.util;StringJoiner;false;StringJoiner;(CharSequence);;Argument[0];Argument[-1];taint;manual"`
`14`	`14`	`StringJoiner out = null;`
`15`	`15`	`CharSequence in = (CharSequence) taint();`
`16`	`16`	`out = new StringJoiner(in);`
`17`	`17`	`sink(out);`
`18`	`18`	`}`
`19`	`19`	`{`
`20`		`- // "java.util;StringJoiner;true;StringJoiner;(CharSequence,CharSequence,CharSequence);;Argument[0];Argument[-1];taint;manual"`
	`20`	`+ // "java.util;StringJoiner;false;StringJoiner;(CharSequence,CharSequence,CharSequence);;Argument[0];Argument[-1];taint;manual"`
`21`	`21`	`StringJoiner out = null;`
`22`	`22`	`CharSequence in = (CharSequence) taint();`
`23`	`23`	`out = new StringJoiner(in, null, null);`
`24`	`24`	`sink(out);`
`25`	`25`	`}`
`26`	`26`	`{`
`27`		`- // "java.util;StringJoiner;true;StringJoiner;(CharSequence,CharSequence,CharSequence);;Argument[1];Argument[-1];taint;manual"`
	`27`	`+ // "java.util;StringJoiner;false;StringJoiner;(CharSequence,CharSequence,CharSequence);;Argument[1];Argument[-1];taint;manual"`
`28`	`28`	`StringJoiner out = null;`
`29`	`29`	`CharSequence in = (CharSequence) taint();`
`30`	`30`	`out = new StringJoiner(null, in, null);`
`31`	`31`	`sink(out);`
`32`	`32`	`}`
`33`	`33`	`{`
`34`		`- // "java.util;StringJoiner;true;StringJoiner;(CharSequence,CharSequence,CharSequence);;Argument[2];Argument[-1];taint;manual"`
	`34`	`+ // "java.util;StringJoiner;false;StringJoiner;(CharSequence,CharSequence,CharSequence);;Argument[2];Argument[-1];taint;manual"`
`35`	`35`	`StringJoiner out = null;`
`36`	`36`	`CharSequence in = (CharSequence) taint();`
`37`	`37`	`out = new StringJoiner(null, null, in);`
`38`	`38`	`sink(out);`
`39`	`39`	`}`
`40`	`40`	`{`
`41`		`- // "java.util;StringJoiner;true;add;;;Argument[-1];ReturnValue;value;manual"`
	`41`	`+ // "java.util;StringJoiner;false;add;;;Argument[-1];ReturnValue;value;manual"`
`42`	`42`	`StringJoiner out = null;`
`43`	`43`	`StringJoiner in = (StringJoiner) taint();`
`44`	`44`	`out = in.add(null);`
`45`	`45`	`sink(out);`
`46`	`46`	`}`
`47`	`47`	`{`
`48`		`- // "java.util;StringJoiner;true;add;;;Argument[0];Argument[-1];taint;manual"`
	`48`	`+ // "java.util;StringJoiner;false;add;;;Argument[0];Argument[-1];taint;manual"`
`49`	`49`	`StringJoiner out = null;`
`50`	`50`	`CharSequence in = (CharSequence) taint();`
`51`	`51`	`out.add(in);`
`52`	`52`	`sink(out);`
`53`	`53`	`}`
`54`	`54`	`{`
`55`		`- // "java.util;StringJoiner;true;merge;;;Argument[-1];ReturnValue;value;manual"`
	`55`	`+ // "java.util;StringJoiner;false;merge;;;Argument[-1];ReturnValue;value;manual"`
`56`	`56`	`StringJoiner out = null;`
`57`	`57`	`StringJoiner in = (StringJoiner) taint();`
`58`	`58`	`out = in.merge(null);`
`59`	`59`	`sink(out);`
`60`	`60`	`}`
`61`	`61`	`{`
`62`		`- // "java.util;StringJoiner;true;merge;;;Argument[0];Argument[-1];taint;manual"`
	`62`	`+ // "java.util;StringJoiner;false;merge;;;Argument[0];Argument[-1];taint;manual"`
`63`	`63`	`StringJoiner out = null;`
`64`	`64`	`StringJoiner in = (StringJoiner) taint();`
`65`	`65`	`out.merge(in);`
`66`	`66`	`sink(out);`
`67`	`67`	`}`
`68`	`68`	`{`
`69`		`- // "java.util;StringJoiner;true;setEmptyValue;;;Argument[-1];ReturnValue;taint;manual"`
	`69`	`+ // "java.util;StringJoiner;false;setEmptyValue;;;Argument[-1];ReturnValue;taint;manual"`
`70`	`70`	`StringJoiner out = null;`
`71`	`71`	`StringJoiner in = (StringJoiner) taint();`
`72`	`72`	`out = in.setEmptyValue(null);`
`73`	`73`	`sink(out);`
`74`	`74`	`}`
`75`	`75`	`{`
`76`		`- // "java.util;StringJoiner;true;setEmptyValue;;;Argument[0];Argument[-1];taint;manual"`
	`76`	`+ // "java.util;StringJoiner;false;setEmptyValue;;;Argument[0];Argument[-1];taint;manual"`
`77`	`77`	`StringJoiner out = null;`
`78`	`78`	`CharSequence in = (CharSequence) taint();`
`79`	`79`	`out.setEmptyValue(in);`
`80`	`80`	`sink(out);`
`81`	`81`	`}`
`82`	`82`	`{`
`83`		`- // "java.util;StringJoiner;true;toString;;;Argument[-1];ReturnValue;taint;manual"`
	`83`	`+ // "java.util;StringJoiner;false;toString;;;Argument[-1];ReturnValue;taint;manual"`
`84`	`84`	`String out = null;`
`85`	`85`	`StringJoiner in = (StringJoiner) taint();`
`86`	`86`	`out = in.toString();`