Change IDiagnosticsWriter to implement IDisposable

tamasvajk · tamasvajk · commit 305fa841862b · 2024-04-03T10:08:46.000+02:00
diff --git a/cpp/autobuilder/Semmle.Autobuild.Cpp.Tests/BuildScripts.cs b/cpp/autobuilder/Semmle.Autobuild.Cpp.Tests/BuildScripts.cs
@@ -203,6 +203,8 @@ internal class TestDiagnosticWriter : IDiagnosticsWriter
         public IList<DiagnosticMessage> Diagnostics { get; } = new List<DiagnosticMessage>();
 
         public void AddEntry(DiagnosticMessage message) => this.Diagnostics.Add(message);
+
+        public void Dispose() { }
     }
 
     /// <summary>
diff --git a/csharp/autobuilder/Semmle.Autobuild.CSharp.Tests/BuildScripts.cs b/csharp/autobuilder/Semmle.Autobuild.CSharp.Tests/BuildScripts.cs
@@ -218,6 +218,8 @@ internal class TestDiagnosticWriter : IDiagnosticsWriter
         public IList<DiagnosticMessage> Diagnostics { get; } = new List<DiagnosticMessage>();
 
         public void AddEntry(DiagnosticMessage message) => this.Diagnostics.Add(message);
+
+        public void Dispose() { }
     }
 
     /// <summary>
diff --git a/csharp/autobuilder/Semmle.Autobuild.Shared/Autobuilder.cs b/csharp/autobuilder/Semmle.Autobuild.Shared/Autobuilder.cs
@@ -361,7 +361,7 @@ protected virtual void Dispose(bool disposing)
         {
             if (disposing)
             {
-                (diagnostics as IDisposable)?.Dispose();
+                diagnostics.Dispose();
             }
         }
 
diff --git a/csharp/extractor/Semmle.Util/ToolStatusPage.cs b/csharp/extractor/Semmle.Util/ToolStatusPage.cs
@@ -183,7 +183,7 @@ public DiagnosticMessage(
     /// <summary>
     /// Provides the ability to write diagnostic messages to some output.
     /// </summary>
-    public interface IDiagnosticsWriter
+    public interface IDiagnosticsWriter : IDisposable
     {
         /// <summary>
         /// Adds <paramref name="message" /> as a new diagnostics entry.

Original file line number	Diff line number	Diff line change
`@@ -203,6 +203,8 @@ internal class TestDiagnosticWriter : IDiagnosticsWriter`
`203`	`203`	`public IList<DiagnosticMessage> Diagnostics { get; } = new List<DiagnosticMessage>();`
`204`	`204`
`205`	`205`	`public void AddEntry(DiagnosticMessage message) => this.Diagnostics.Add(message);`
	`206`	`+`
	`207`	`+ public void Dispose() { }`
`206`	`208`	`}`
`207`	`209`
`208`	`210`	`/// <summary>`
Original file line number	Diff line number	Diff line change
`@@ -218,6 +218,8 @@ internal class TestDiagnosticWriter : IDiagnosticsWriter`
`218`	`218`	`public IList<DiagnosticMessage> Diagnostics { get; } = new List<DiagnosticMessage>();`
`219`	`219`
`220`	`220`	`public void AddEntry(DiagnosticMessage message) => this.Diagnostics.Add(message);`
	`221`	`+`
	`222`	`+ public void Dispose() { }`
`221`	`223`	`}`
`222`	`224`
`223`	`225`	`/// <summary>`
Original file line number	Diff line number	Diff line change
`@@ -361,7 +361,7 @@ protected virtual void Dispose(bool disposing)`
`361`	`361`	`{`
`362`	`362`	`if (disposing)`
`363`	`363`	`{`
`364`		`- (diagnostics as IDisposable)?.Dispose();`
	`364`	`+ diagnostics.Dispose();`
`365`	`365`	`}`
`366`	`366`	`}`
`367`	`367`
Original file line number	Diff line number	Diff line change
`@@ -183,7 +183,7 @@ public DiagnosticMessage(`
`183`	`183`	`/// <summary>`
`184`	`184`	`/// Provides the ability to write diagnostic messages to some output.`
`185`	`185`	`/// </summary>`
`186`		`- public interface IDiagnosticsWriter`
	`186`	`+ public interface IDiagnosticsWriter : IDisposable`
`187`	`187`	`{`
`188`	`188`	`/// <summary>`
`189`	`189`	`/// Adds <paramref name="message" /> as a new diagnostics entry.`