rename the V class to WriteSuccessorsVisitor

erik-krogh · erik-krogh · commit 366a16f70072 · 2021-08-03T08:59:33.000+02:00
diff --git a/javascript/extractor/src/com/semmle/js/extractor/CFGExtractor.java b/javascript/extractor/src/com/semmle/js/extractor/CFGExtractor.java
@@ -111,6 +111,7 @@
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.Collections;
+import java.util.function.IntFunction;
 import java.util.HashMap;
 import java.util.Iterator;
 import java.util.LinkedHashMap;
@@ -737,7 +738,11 @@ public <Q, A> A accept(Visitor<Q, A> v, Q q) {
     return result;
   }
 
-  private class V extends DefaultVisitor<SuccessorInfo, Void> {
+  /**
+   * A visitor that recursively visits all the nodes in the CFG (starting with the top-level `Program`) and writes the `successor` relation for each of the nodes.
+   * Depends on the `First` visitor to compute which CFG-node is first in the CFG for a given parent-node.
+   */
+  private class WriteSuccessorsVisitor extends DefaultVisitor<SuccessorInfo, Void> {
     /**
      * The context stores relevant bits of syntactic context to be able to resolve jumps.
      *
@@ -1990,7 +1995,7 @@ public Void visit(XMLDotDotExpression nd, SuccessorInfo c) {
 
   public void extract(Node nd) {
     metrics.startPhase(ExtractionPhase.CFGExtractor_extract);
-    nd.accept(new V(), new SimpleSuccessorInfo(null));
+    nd.accept(new WriteSuccessorsVisitor(), new SimpleSuccessorInfo(null));
     metrics.stopPhase(ExtractionPhase.CFGExtractor_extract);
   }
 }
