C++: Simplify 'getSourceVariable'.

MathiasVP · MathiasVP · commit 36d09037338c · 2022-12-08T12:29:15.000Z
diff --git a/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/ssa0/SsaInternals.qll b/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/ssa0/SsaInternals.qll
@@ -61,10 +61,7 @@ abstract private class DefOrUseImpl extends TDefOrUseImpl {
 
   /** Gets the variable that is defined or used. */
   final SourceVariable getSourceVariable() {
-    exists(BaseSourceVariable v |
-      result.getBaseVariable() = v and
-      this.getBaseSourceVariable() = v
-    )
+    result.getBaseVariable() = this.getBaseSourceVariable()
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -61,10 +61,7 @@ abstract private class DefOrUseImpl extends TDefOrUseImpl {`
`61`	`61`
`62`	`62`	`/** Gets the variable that is defined or used. */`
`63`	`63`	`final SourceVariable getSourceVariable() {`
`64`		`- exists(BaseSourceVariable v \|`
`65`		`- result.getBaseVariable() = v and`
`66`		`- this.getBaseSourceVariable() = v`
`67`		`- )`
	`64`	`+ result.getBaseVariable() = this.getBaseSourceVariable()`
`68`	`65`	`}`
`69`	`66`	`}`
`70`	`67`