JS: add PropWrite for instance fields with initializer

asger-semmle · asger-semmle · commit 383cadb25b3f · 2019-01-28T15:40:30.000Z
diff --git a/javascript/ql/src/semmle/javascript/dataflow/DataFlow.qll b/javascript/ql/src/semmle/javascript/dataflow/DataFlow.qll
@@ -531,6 +531,31 @@ module DataFlow {
     override ControlFlowNode getWriteNode() { result = prop.getParameter() }
   }
 
+  /**
+   * An instance field with an initializer expression, seen as a property write.
+   */
+  private class InstanceFieldAsPropWrite extends PropWrite, PropNode {
+    override FieldDefinition prop;
+
+    InstanceFieldAsPropWrite() {
+      not prop.isStatic() and
+      exists(prop.getInit()) and
+      not prop instanceof ParameterField
+    }
+
+    override Node getBase() {
+      result = thisNode(prop.getDeclaringClass().getConstructor().getBody())
+    }
+
+    override Expr getPropertyNameExpr() { result = prop.getNameExpr() }
+
+    override string getPropertyName() { result = prop.getName() }
+
+    override Node getRhs() { result = valueNode(prop.getInit()) }
+
+    override ControlFlowNode getWriteNode() { result = prop }
+  }
+
   /**
    * A data flow node that reads an object property.
    */
