Fix 1

haby0 · haby0 · commit 3a2a99e28957 · 2021-06-18T21:36:44.000+08:00
diff --git a/java/ql/src/experimental/Security/CWE/CWE-094/JShellInjection.qhelp b/java/ql/src/experimental/Security/CWE/CWE-094/JShellInjection.qhelp
@@ -13,7 +13,7 @@ it may allow the attacker to run arbitrary code.</p>
 
 <recommendation>
 <p>It is generally recommended to avoid using untrusted input in a JShell expression.
-If it is not possible,JShell expressions should be run in a sandbox that allows accessing only 
+If it is not possible, JShell expressions should be run in a sandbox that allows accessing only 
 explicitly allowed classes.</p>
 </recommendation>
 
@@ -25,7 +25,7 @@ to execute untrusted data.</p>
 
 <references>
 <li>
-Java 9 jshell tutorial: <a href="https://examples.javacodegeeks.com/core-java/java-9-jshell-tutorial/">JShell introduction</a>
+Introduction to JShell: <a href="https://docs.oracle.com/en/java/javase/11/jshell/introduction-jshell.html">Java Shell User’s Guide</a>
 </li>
 </references>
 </qhelp>
diff --git a/java/ql/src/experimental/Security/CWE/CWE-094/JShellInjection.ql b/java/ql/src/experimental/Security/CWE/CWE-094/JShellInjection.ql
@@ -22,15 +22,15 @@ class JShellInjectionConfiguration extends TaintTracking::Configuration {
 
   override predicate isSink(DataFlow::Node sink) { sink instanceof JShellInjectionSink }
 
-  override predicate isAdditionalTaintStep(DataFlow::Node prod, DataFlow::Node succ) {
+  override predicate isAdditionalTaintStep(DataFlow::Node pred, DataFlow::Node succ) {
     exists(MethodAccess ma |
       ma.getMethod().hasName("analyzeCompletion") and
       ma.getMethod().getNumberOfParameters() = 1 and
       ma.getMethod()
           .getDeclaringType()
           .getASupertype*()
           .hasQualifiedName("jdk.jshell", "SourceCodeAnalysis") and
-      ma.getArgument(0) = prod.asExpr() and
+      ma.getArgument(0) = pred.asExpr() and
       ma = succ.asExpr()
     )
   }
