Remove unnecessary unchecked cast

smowton · smowton · commit 3dc9c2e57ba2 · 2022-12-09T10:33:04.000Z
diff --git a/java/kotlin-extractor/src/main/kotlin/KotlinFileExtractor.kt b/java/kotlin-extractor/src/main/kotlin/KotlinFileExtractor.kt
@@ -4564,8 +4564,7 @@ open class KotlinFileExtractor(
         extractExpressionExpr(loop.condition, callable, id, 0, id)
     }
 
-    @Suppress("UNCHECKED_CAST")
-    private fun <T : DbExpr> exprIdOrFresh(id: Label<out DbExpr>?) = id as? Label<T> ?: tw.getFreshIdLabel()
+    private fun <T : DbExpr> exprIdOrFresh(id: Label<out DbExpr>?) = id?.cast<T>() ?: tw.getFreshIdLabel()
 
     private fun toUnbound(t: IrType) =
         when(t) {

Original file line number	Diff line number	Diff line change
`@@ -4564,8 +4564,7 @@ open class KotlinFileExtractor(`
`4564`	`4564`	`extractExpressionExpr(loop.condition, callable, id, 0, id)`
`4565`	`4565`	`}`
`4566`	`4566`
`4567`		`- @Suppress("UNCHECKED_CAST")`
`4568`		`- private fun <T : DbExpr> exprIdOrFresh(id: Label<out DbExpr>?) = id as? Label<T> ?: tw.getFreshIdLabel()`
	`4567`	`+ private fun <T : DbExpr> exprIdOrFresh(id: Label<out DbExpr>?) = id?.cast<T>() ?: tw.getFreshIdLabel()`
`4569`	`4568`
`4570`	`4569`	`private fun toUnbound(t: IrType) =`
`4571`	`4570`	`when(t) {`