Revert "Add method access qualifier as source"

luchua-bc · luchua-bc · commit 3e8e9f996920 · 2020-06-30T00:54:27.000Z
This reverts commit 87668bf.
diff --git a/java/ql/src/semmle/code/java/dataflow/FlowSources.qll b/java/ql/src/semmle/code/java/dataflow/FlowSources.qll
@@ -298,10 +298,7 @@ private class AndroidIntentExtraSource extends RemoteFlowSource {
   AndroidIntentExtraSource() {
     exists(MethodAccess ma |
       ma instanceof IntentGetExtraMethodAccess and
-      (
-        this.asExpr().(VarAccess).getVariable().getAnAssignedValue() = ma or
-        ma.getQualifier() = this.asExpr()
-      )
+      this.asExpr().(VarAccess).getVariable().getAnAssignedValue() = ma
     )
   }
 

Original file line number	Diff line number	Diff line change
`@@ -298,10 +298,7 @@ private class AndroidIntentExtraSource extends RemoteFlowSource {`
`298`	`298`	`AndroidIntentExtraSource() {`
`299`	`299`	`exists(MethodAccess ma \|`
`300`	`300`	`ma instanceof IntentGetExtraMethodAccess and`
`301`		`- (`
`302`		`- this.asExpr().(VarAccess).getVariable().getAnAssignedValue() = ma or`
`303`		`- ma.getQualifier() = this.asExpr()`
`304`		`- )`
	`301`	`+ this.asExpr().(VarAccess).getVariable().getAnAssignedValue() = ma`
`305`	`302`	`)`
`306`	`303`	`}`
`307`	`304`