Fix comment describing two-arg nextInt/nextLong

smowton · Marcono1234 · web-flow · commit 410f21cd55e8 · 2021-03-10T08:43:37.000Z
Co-authored-by: Marcono1234 &lt;Marcono1234@users.noreply.github.com&gt;
diff --git a/java/ql/src/semmle/code/java/security/Random.qll b/java/ql/src/semmle/code/java/security/Random.qll
@@ -110,7 +110,7 @@ class StdlibRandomSource extends RandomDataSource {
 
   override Expr getUpperBoundExpr() {
     // If this call is to `nextInt(int)` or `nextLong(long)`, the upper bound is the first argument.
-    // If it calls `nextInt(int, int)` or `nextLong(long, long)`, the upper bound is the first argument.
+    // If it calls `nextInt(int, int)` or `nextLong(long, long)`, the upper bound is the second argument.
     m.hasName(["nextInt", "nextLong"]) and
     (
       m.getNumberOfParameters() = 1 and

Original file line number	Diff line number	Diff line change
`@@ -110,7 +110,7 @@ class StdlibRandomSource extends RandomDataSource {`
`110`	`110`
`111`	`111`	`override Expr getUpperBoundExpr() {`
`112`	`112`	// If this call is to `nextInt(int)` or `nextLong(long)`, the upper bound is the first argument.
`113`		- // If it calls `nextInt(int, int)` or `nextLong(long, long)`, the upper bound is the first argument.
	`113`	+ // If it calls `nextInt(int, int)` or `nextLong(long, long)`, the upper bound is the second argument.
`114`	`114`	`m.hasName(["nextInt", "nextLong"]) and`
`115`	`115`	`(`
`116`	`116`	`m.getNumberOfParameters() = 1 and`