Fix path transformer handling of extensionless files

Dave Bartolomeo · Dave Bartolomeo · commit 42e075dfb855 · 2020-10-29T10:02:55.000-04:00
diff --git a/csharp/extractor/Semmle.Extraction/PathTransformer.cs b/csharp/extractor/Semmle.Extraction/PathTransformer.cs
@@ -44,7 +44,21 @@ private struct TransformedPath : ITransformedPath
 
             public string Value => value;
 
-            public string Extension => Path.GetExtension(value)?.Substring(1) ?? "";
+            public string Extension
+            {
+                get
+                {
+                    var extension = Path.GetExtension(value);
+                    if (string.IsNullOrEmpty(extension))
+                    {
+                        return "";
+                    }
+                    else
+                    {
+                        return extension.Substring(1);
+                    }
+                }
+            }
 
             public string NameWithoutExtension => Path.GetFileNameWithoutExtension(value);
 
