Don't restrict inputs to be ParameterNodes

atorralba · aschackmull · web-flow · commit 46eb27cd0144 · 2021-09-28T11:21:56.000+02:00
Co-authored-by: Anders Schack-Mulligen &lt;aschackmull@users.noreply.github.com&gt;
diff --git a/java/ql/lib/semmle/code/java/dataflow/FlowSources.qll b/java/ql/lib/semmle/code/java/dataflow/FlowSources.qll
@@ -254,7 +254,7 @@ class AndroidContentProviderInput extends DataFlow::Node {
 
   AndroidContentProviderInput() {
     sourceNode(this, "contentprovider") and
-    this.asParameter().getCallable().getDeclaringType() = declaringType
+    this.getEnclosingCallable().getDeclaringType() = declaringType
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -254,7 +254,7 @@ class AndroidContentProviderInput extends DataFlow::Node {`
`254`	`254`
`255`	`255`	`AndroidContentProviderInput() {`
`256`	`256`	`sourceNode(this, "contentprovider") and`
`257`		`- this.asParameter().getCallable().getDeclaringType() = declaringType`
	`257`	`+ this.getEnclosingCallable().getDeclaringType() = declaringType`
`258`	`258`	`}`
`259`	`259`	`}`
`260`	`260`