Fixes based on the PR comments

raulgarciamsft · raulgarciamsft · commit 476562ec62ab · 2022-08-31T12:32:47.000-07:00
diff --git a/csharp/ql/src/experimental/Security Features/JsonWebTokenHandler/JsonWebTokenHandlerLib.qll b/csharp/ql/src/experimental/Security Features/JsonWebTokenHandler/JsonWebTokenHandlerLib.qll
@@ -32,10 +32,7 @@ class FalseValueFlowsToTokenValidationParametersPropertyWriteToBypassValidation
   }
 
   override predicate isSink(DataFlow::Node sink) {
-    exists(Assignment a |
-      sink.asExpr() =
-        any(TokenValidationParametersPropertySensitiveValidation p).getAnAssignedValue()
-    )
+    sink.asExpr() = any(TokenValidationParametersPropertySensitiveValidation p).getAnAssignedValue()
   }
 }
 
@@ -245,7 +242,7 @@ class CallableAlwaysReturnsParameter0MayThrowExceptions extends CallableReturnsS
 predicate isExpressionAlwaysTrue(Expr e) {
   e.(BoolLiteral).getBoolValue() = true
   or
-  e.(Expr).getValue() = "true"
+  e.getValue() = "true"
   or
   e instanceof ConditionalExpr and
   isExpressionAlwaysTrue(e.(ConditionalExpr).getThen()) and

Original file line number	Diff line number	Diff line change
`@@ -32,10 +32,7 @@ class FalseValueFlowsToTokenValidationParametersPropertyWriteToBypassValidation`
`32`	`32`	`}`
`33`	`33`
`34`	`34`	`override predicate isSink(DataFlow::Node sink) {`
`35`		`- exists(Assignment a \|`
`36`		`- sink.asExpr() =`
`37`		`- any(TokenValidationParametersPropertySensitiveValidation p).getAnAssignedValue()`
`38`		`- )`
	`35`	`+ sink.asExpr() = any(TokenValidationParametersPropertySensitiveValidation p).getAnAssignedValue()`
`39`	`36`	`}`
`40`	`37`	`}`
`41`	`38`
`@@ -245,7 +242,7 @@ class CallableAlwaysReturnsParameter0MayThrowExceptions extends CallableReturnsS`
`245`	`242`	`predicate isExpressionAlwaysTrue(Expr e) {`
`246`	`243`	`e.(BoolLiteral).getBoolValue() = true`
`247`	`244`	`or`
`248`		`- e.(Expr).getValue() = "true"`
	`245`	`+ e.getValue() = "true"`
`249`	`246`	`or`
`250`	`247`	`e instanceof ConditionalExpr and`
`251`	`248`	`isExpressionAlwaysTrue(e.(ConditionalExpr).getThen()) and`