Consider more startService methods

atorralba · atorralba · commit 47c851efaf5d · 2022-01-14T10:31:59.000+01:00
diff --git a/java/ql/lib/semmle/code/java/security/ImplicitPendingIntents.qll b/java/ql/lib/semmle/code/java/security/ImplicitPendingIntents.qll
@@ -51,6 +51,7 @@ private class DefaultIntentRedirectionSinkModel extends SinkModelCsv {
         "android.content;Context;true;startActivityFromChild;;;Argument[1];intent-start",
         "android.content;Context;true;startActivityFromFragment;;;Argument[1];intent-start",
         "android.content;Context;true;startActivityIfNeeded;;;Argument[0];intent-start",
+        "android.content;Context;true;startForegroundService;;;Argument[0];intent-start",
         "android.content;Context;true;startService;;;Argument[0];intent-start",
         "android.content;Context;true;startServiceAsUser;;;Argument[0];intent-start",
         "android.content;Context;true;sendBroadcast;;;Argument[0];intent-start",
diff --git a/java/ql/lib/semmle/code/java/security/ImplicitPendingIntentsQuery.qll b/java/ql/lib/semmle/code/java/security/ImplicitPendingIntentsQuery.qll
@@ -64,7 +64,7 @@ private class SendPendingIntent extends DataFlow::Node {
     not exists(MethodAccess ma, Method m |
       ma.getMethod() = m and
       m.getDeclaringType().getASupertype*() instanceof TypeContext and
-      m.hasName("startService") and
+      m.getName().matches("start%Service%") and
       this.asExpr() = ma.getArgument(0)
     )
     or

Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ private class SendPendingIntent extends DataFlow::Node {`
`64`	`64`	`not exists(MethodAccess ma, Method m \|`
`65`	`65`	`ma.getMethod() = m and`
`66`	`66`	`m.getDeclaringType().getASupertype*() instanceof TypeContext and`
`67`		`- m.hasName("startService") and`
	`67`	`+ m.getName().matches("start%Service%") and`
`68`	`68`	`this.asExpr() = ma.getArgument(0)`
`69`	`69`	`)`
`70`	`70`	`or`