Java: Improve Annotation.getAnAssociatedAnnotation

Marcono1234 · smowton · commit 47e38952d167 · 2022-09-16T15:49:16.000+01:00
As suggested by smowton during review.
diff --git a/java/ql/lib/semmle/code/java/Annotation.qll b/java/ql/lib/semmle/code/java/Annotation.qll
@@ -217,13 +217,15 @@ class Annotatable extends Element {
     )
   }
 
-  private Annotation getAnAssociatedAnnotation(AnnotationType t) {
-    result.getType() = t and
+  private Annotation getADeclaredAssociatedAnnotation(AnnotationType t) {
     // Direct or indirect annotation
-    if getADeclaredAnnotation().getType() = t or getAnIndirectAnnotation().getType() = t
-    then (
-      result = getADeclaredAnnotation() or result = getAnIndirectAnnotation()
-    ) else (
+    result.getType() = t and result = [getADeclaredAnnotation(), getAnIndirectAnnotation()]
+  }
+
+  private Annotation getAnAssociatedAnnotation(AnnotationType t) {
+    if exists(getADeclaredAssociatedAnnotation(t))
+    then result = getADeclaredAssociatedAnnotation(t)
+    else (
       // Only if neither a direct nor an indirect annotation is present look for an inherited one
       t.isInherited() and
       // @Inherited only works for classes; cast to Annotatable is necessary because predicate is private
