Update models to include manual tag

joefarebrother · atorralba · commit 49b419c52ec0 · 2022-06-28T10:10:28.000+02:00
diff --git a/java/ql/lib/semmle/code/java/frameworks/android/ExternalStorage.qll b/java/ql/lib/semmle/code/java/frameworks/android/ExternalStorage.qll
@@ -10,12 +10,12 @@ private class ExternalStorageDirSourceModel extends SourceModelCsv {
     row =
       [
         //"package;type;overrides;name;signature;ext;spec;kind"
-        "android.content;Context;true;getExternalFilesDir;(String);;ReturnValue;android-external-storage-dir",
-        "android.content;Context;true;getExternalFilesDirs;(String);;ReturnValue;android-external-storage-dir",
-        "android.content;Context;true;getExternalCacheDir;();;ReturnValue;android-external-storage-dir",
-        "android.content;Context;true;getExternalCacheDirs;();;ReturnValue;android-external-storage-dir",
-        "android.os;Environment;false;getExternalStorageDirectory;();;ReturnValue;android-external-storage-dir",
-        "android.os;Environment;false;getExternalStoragePublicDirectory;(String);;ReturnValue;android-external-storage-dir",
+        "android.content;Context;true;getExternalFilesDir;(String);;ReturnValue;android-external-storage-dir;manual",
+        "android.content;Context;true;getExternalFilesDirs;(String);;ReturnValue;android-external-storage-dir;manual",
+        "android.content;Context;true;getExternalCacheDir;();;ReturnValue;android-external-storage-dir;manual",
+        "android.content;Context;true;getExternalCacheDirs;();;ReturnValue;android-external-storage-dir;manual",
+        "android.os;Environment;false;getExternalStorageDirectory;();;ReturnValue;android-external-storage-dir;manual",
+        "android.os;Environment;false;getExternalStoragePublicDirectory;(String);;ReturnValue;android-external-storage-dir;manual",
       ]
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -10,12 +10,12 @@ private class ExternalStorageDirSourceModel extends SourceModelCsv {`
`10`	`10`	`row =`
`11`	`11`	`[`
`12`	`12`	`//"package;type;overrides;name;signature;ext;spec;kind"`
`13`		`- "android.content;Context;true;getExternalFilesDir;(String);;ReturnValue;android-external-storage-dir",`
`14`		`- "android.content;Context;true;getExternalFilesDirs;(String);;ReturnValue;android-external-storage-dir",`
`15`		`- "android.content;Context;true;getExternalCacheDir;();;ReturnValue;android-external-storage-dir",`
`16`		`- "android.content;Context;true;getExternalCacheDirs;();;ReturnValue;android-external-storage-dir",`
`17`		`- "android.os;Environment;false;getExternalStorageDirectory;();;ReturnValue;android-external-storage-dir",`
`18`		`- "android.os;Environment;false;getExternalStoragePublicDirectory;(String);;ReturnValue;android-external-storage-dir",`
	`13`	`+ "android.content;Context;true;getExternalFilesDir;(String);;ReturnValue;android-external-storage-dir;manual",`
	`14`	`+ "android.content;Context;true;getExternalFilesDirs;(String);;ReturnValue;android-external-storage-dir;manual",`
	`15`	`+ "android.content;Context;true;getExternalCacheDir;();;ReturnValue;android-external-storage-dir;manual",`
	`16`	`+ "android.content;Context;true;getExternalCacheDirs;();;ReturnValue;android-external-storage-dir;manual",`
	`17`	`+ "android.os;Environment;false;getExternalStorageDirectory;();;ReturnValue;android-external-storage-dir;manual",`
	`18`	`+ "android.os;Environment;false;getExternalStoragePublicDirectory;(String);;ReturnValue;android-external-storage-dir;manual",`
`19`	`19`	`]`
`20`	`20`	`}`
`21`	`21`	`}`