JavaScript: Add a negative test for API graphs.

Max Schaefer · Max Schaefer · commit 4bf6f6ac7ca3 · 2020-10-08T19:53:23.000+01:00
The test ensures that flow summarization won't label property `f` of the first parameter of `assertNotNull` as a sink, which would be very imprecise.
diff --git a/javascript/ql/test/ApiGraphs/property-read-from-argument/VerifyAssertions.expected b/javascript/ql/test/ApiGraphs/property-read-from-argument/VerifyAssertions.expected
diff --git a/javascript/ql/test/ApiGraphs/property-read-from-argument/VerifyAssertions.ql b/javascript/ql/test/ApiGraphs/property-read-from-argument/VerifyAssertions.ql
@@ -0,0 +1 @@
+import ApiGraphs.VerifyAssertions
diff --git a/javascript/ql/test/ApiGraphs/property-read-from-argument/index.js b/javascript/ql/test/ApiGraphs/property-read-from-argument/index.js
@@ -0,0 +1,9 @@
+exports.assertNotNull = function (x) {
+    if (x === null)
+        throw new TypeError();
+}
+
+exports.foo = function(x) {
+    exports.assertNotNull(x);
+    sink(x.f); /* !use (member f (parameter 0 (member assertNotNull (member exports (module property-read-from-argument))))) */ /* use (member f (parameter 0 (member foo (member exports (module property-read-from-argument))))) */
+}
diff --git a/javascript/ql/test/ApiGraphs/property-read-from-argument/package.json b/javascript/ql/test/ApiGraphs/property-read-from-argument/package.json
@@ -0,0 +1,3 @@
+{
+    "name": "property-read-from-argument"
+}

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+{`
	`2`	`+ "name": "property-read-from-argument"`
	`3`	`+}`