Merge pull request #9641 from boveus/patch-1

alexrford · web-flow · commit 578a96716003 · 2022-06-29T14:39:36.000+01:00
Make ActiveRecordInstanceMethodCall Public
diff --git a/ruby/ql/lib/codeql/ruby/frameworks/ActiveRecord.qll b/ruby/ql/lib/codeql/ruby/frameworks/ActiveRecord.qll
@@ -330,12 +330,13 @@ class ActiveRecordInstance extends DataFlow::Node {
   ActiveRecordModelClass getClass() { result = instantiation.getClass() }
 }
 
-// A call whose receiver may be an active record model object
-private class ActiveRecordInstanceMethodCall extends DataFlow::CallNode {
+/** A call whose receiver may be an active record model object */
+class ActiveRecordInstanceMethodCall extends DataFlow::CallNode {
   private ActiveRecordInstance instance;
 
   ActiveRecordInstanceMethodCall() { this.getReceiver() = instance }
 
+  /** Gets the `ActiveRecordInstance` that is the receiver of this call. */
   ActiveRecordInstance getInstance() { result = instance }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -330,12 +330,13 @@ class ActiveRecordInstance extends DataFlow::Node {`
`330`	`330`	`ActiveRecordModelClass getClass() { result = instantiation.getClass() }`
`331`	`331`	`}`
`332`	`332`
`333`		`-// A call whose receiver may be an active record model object`
`334`		`-private class ActiveRecordInstanceMethodCall extends DataFlow::CallNode {`
	`333`	`+/** A call whose receiver may be an active record model object */`
	`334`	`+class ActiveRecordInstanceMethodCall extends DataFlow::CallNode {`
`335`	`335`	`private ActiveRecordInstance instance;`
`336`	`336`
`337`	`337`	`ActiveRecordInstanceMethodCall() { this.getReceiver() = instance }`
`338`	`338`
	`339`	+ /** Gets the `ActiveRecordInstance` that is the receiver of this call. */
`339`	`340`	`ActiveRecordInstance getInstance() { result = instance }`
`340`	`341`	`}`
`341`	`342`