C#: Add test for CIL setter extraction

tamasvajk · tamasvajk · commit 57c163f31413 · 2020-12-17T15:23:33.000+01:00
diff --git a/csharp/ql/src/semmle/code/cil/Method.qll b/csharp/ql/src/semmle/code/cil/Method.qll
@@ -246,6 +246,9 @@ class Setter extends Accessor {
   Setter() { cil_setter(_, this) }
 
   override Property getProperty() { cil_setter(result, this) }
+
+  /** Holds if this setter is an `init`-only accessor. */
+  predicate isInitOnly() { none() }
 }
 
 /**
diff --git a/csharp/ql/test/library-tests/cil/init-only-prop/Program.cs b/csharp/ql/test/library-tests/cil/init-only-prop/Program.cs
@@ -0,0 +1,10 @@
+// semmle-extractor-options: --cil
+
+using System;
+
+class Test
+{
+    static void Main(string[] args)
+    {
+    }
+}
diff --git a/csharp/ql/test/library-tests/cil/init-only-prop/Test.cs_ b/csharp/ql/test/library-tests/cil/init-only-prop/Test.cs_
@@ -0,0 +1,13 @@
+﻿namespace System.Runtime.CompilerServices
+{
+    class IsExternalInit { }
+}
+
+namespace cil_init_prop
+{
+    class SomeClass
+    {
+        public int Prop1 { get; set; }
+        public int Prop2 { get; init; }
+    }
+}
diff --git a/csharp/ql/test/library-tests/cil/init-only-prop/cil-init-prop.dll b/csharp/ql/test/library-tests/cil/init-only-prop/cil-init-prop.dll
diff --git a/csharp/ql/test/library-tests/cil/init-only-prop/setters.expected b/csharp/ql/test/library-tests/cil/init-only-prop/setters.expected
@@ -0,0 +1,2 @@
+| cil-init-prop.dll:0:0:0:0 | set_Prop1 | set |
+| cil-init-prop.dll:0:0:0:0 | set_Prop2 | set |
diff --git a/csharp/ql/test/library-tests/cil/init-only-prop/setters.ql b/csharp/ql/test/library-tests/cil/init-only-prop/setters.ql
@@ -0,0 +1,8 @@
+import semmle.code.cil.Method
+import semmle.code.csharp.Location
+
+private string getType(Setter s) { if s.isInitOnly() then result = "init" else result = "set" }
+
+from Setter s
+where s.getLocation().(Assembly).getName() = "cil-init-prop"
+select s, getType(s)

Original file line number	Diff line number	Diff line change
`@@ -246,6 +246,9 @@ class Setter extends Accessor {`
`246`	`246`	`Setter() { cil_setter(_, this) }`
`247`	`247`
`248`	`248`	`override Property getProperty() { cil_setter(result, this) }`
	`249`	`+`
	`250`	+ /** Holds if this setter is an `init`-only accessor. */
	`251`	`+ predicate isInitOnly() { none() }`
`249`	`252`	`}`
`250`	`253`
`251`	`254`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+\| cil-init-prop.dll:0:0:0:0 \| set_Prop1 \| set \|`
	`2`	`+\| cil-init-prop.dll:0:0:0:0 \| set_Prop2 \| set \|`