Apply suggestions from code review

atorralba · smowton · atorralba · commit 58a0bcd70f82 · 2022-01-20T13:23:53.000+01:00
Co-authored-by: Chris Smowton &lt;smowton@github.com&gt;
diff --git a/java/ql/lib/semmle/code/java/security/IntentUriPermissionManipulation.qll b/java/ql/lib/semmle/code/java/security/IntentUriPermissionManipulation.qll
@@ -72,6 +72,8 @@ private class IntentFlagsOrDataCheckedGuard extends IntentUriPermissionManipulat
 
   override predicate checks(Expr e, boolean branch) {
     exists(MethodAccess ma, Method m |
+      // This checks `intent` when the result of an `intent.getFlags` or `intent.getData` call flows to `condition`
+      // (i.e., that result is equality-tested)
       ma.getMethod() = m and
       m.getDeclaringType() instanceof TypeIntent and
       m.hasName(["getFlags", "getData"]) and
