Move TransformPath into FileLabelFor

owen-mc · owen-mc · commit 59ac2d3d3e18 · 2025-11-14T10:25:40.000Z
This way we don't have to remember to transform it at all call sites.
diff --git a/go/extractor/extractor.go b/go/extractor/extractor.go
@@ -815,12 +815,12 @@ func (extraction *Extraction) extractFileInfo(tw *trap.Writer, file string, isDu
 			displayPath = rawPath
 		}
 		if i == len(components)-1 {
-			lbl := tw.Labeler.FileLabelFor(path)
+			lbl := tw.Labeler.FileLabelFor(file)
 			dbscheme.FilesTable.Emit(tw, lbl, displayPath)
 			dbscheme.ContainerParentTable.Emit(tw, parentLbl, lbl)
 			dbscheme.HasLocationTable.Emit(tw, lbl, emitLocation(tw, lbl, 0, 0, 0, 0))
 			extraction.Lock.Lock()
-			slbl := extraction.StatWriter.Labeler.FileLabelFor(path)
+			slbl := extraction.StatWriter.Labeler.FileLabelFor(file)
 			if !isDummy {
 				dbscheme.CompilationCompilingFilesTable.Emit(extraction.StatWriter, extraction.Label, extraction.GetFileIdx(file), slbl)
 			}
diff --git a/go/extractor/trap/labels.go b/go/extractor/trap/labels.go
@@ -69,14 +69,14 @@ func (l *Labeler) GlobalID(key string) Label {
 // FileLabel returns the label for a file with path `path`.
 func (l *Labeler) FileLabel() Label {
 	if l.fileLabel == InvalidLabel {
-		l.fileLabel = l.FileLabelFor(srcarchive.TransformPath(l.tw.path))
+		l.fileLabel = l.FileLabelFor(l.tw.path)
 	}
 	return l.fileLabel
 }
 
 // FileLabelFor returns the label for the file for which the trap writer `tw` is associated
 func (l *Labeler) FileLabelFor(path string) Label {
-	return l.GlobalID(util.EscapeTrapSpecialChars(filepath.ToSlash(path)) + ";sourcefile")
+	return l.GlobalID(util.EscapeTrapSpecialChars(filepath.ToSlash(srcarchive.TransformPath(path))) + ";sourcefile")
 }
 
 // LocalID associates a label with the given AST node `nd` and returns it

Original file line number	Diff line number	Diff line change
`@@ -69,14 +69,14 @@ func (l *Labeler) GlobalID(key string) Label {`
`69`	`69`	// FileLabel returns the label for a file with path `path`.
`70`	`70`	`func (l *Labeler) FileLabel() Label {`
`71`	`71`	`if l.fileLabel == InvalidLabel {`
`72`		`- l.fileLabel = l.FileLabelFor(srcarchive.TransformPath(l.tw.path))`
	`72`	`+ l.fileLabel = l.FileLabelFor(l.tw.path)`
`73`	`73`	`}`
`74`	`74`	`return l.fileLabel`
`75`	`75`	`}`
`76`	`76`
`77`	`77`	// FileLabelFor returns the label for the file for which the trap writer `tw` is associated
`78`	`78`	`func (l *Labeler) FileLabelFor(path string) Label {`
`79`		`- return l.GlobalID(util.EscapeTrapSpecialChars(filepath.ToSlash(path)) + ";sourcefile")`
	`79`	`+ return l.GlobalID(util.EscapeTrapSpecialChars(filepath.ToSlash(srcarchive.TransformPath(path))) + ";sourcefile")`
`80`	`80`	`}`
`81`	`81`
`82`	`82`	// LocalID associates a label with the given AST node `nd` and returns it