add support for replace in Next.js router

erik-krogh · erik-krogh · commit 5b5baced9ac5 · 2021-03-02T12:25:49.000+01:00
diff --git a/javascript/ql/src/semmle/javascript/security/dataflow/ClientSideUrlRedirectCustomizations.qll b/javascript/ql/src/semmle/javascript/security/dataflow/ClientSideUrlRedirectCustomizations.qll
@@ -182,6 +182,8 @@ module ClientSideUrlRedirect {
    * A call to change the current url with a Next.js router.
    */
   class NextRoutePushUrlSink extends ScriptUrlSink {
-    NextRoutePushUrlSink() { this = NextJS::nextRouter().getAMemberCall("push").getArgument(0) }
+    NextRoutePushUrlSink() {
+      this = NextJS::nextRouter().getAMemberCall(["push", "replace"]).getArgument(0)
+    }
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -182,6 +182,8 @@ module ClientSideUrlRedirect {`
`182`	`182`	`* A call to change the current url with a Next.js router.`
`183`	`183`	`*/`
`184`	`184`	`class NextRoutePushUrlSink extends ScriptUrlSink {`
`185`		`- NextRoutePushUrlSink() { this = NextJS::nextRouter().getAMemberCall("push").getArgument(0) }`
	`185`	`+ NextRoutePushUrlSink() {`
	`186`	`+ this = NextJS::nextRouter().getAMemberCall(["push", "replace"]).getArgument(0)`
	`187`	`+ }`
`186`	`188`	`}`
`187`	`189`	`}`