Kotlin: Respect override modifier in useless parameter query

tamasvajk · tamasvajk · commit 5ce2573cc154 · 2022-05-13T11:08:35.000+02:00
diff --git a/java/ql/lib/semmle/code/java/deadcode/DeadCode.qll b/java/ql/lib/semmle/code/java/deadcode/DeadCode.qll
@@ -302,6 +302,8 @@ class RootdefCallable extends Callable {
     exists(MemberRefExpr mre | mre.getReferencedCallable() = this)
     or
     this.getAnAnnotation() instanceof OverrideAnnotation
+    or
+    this.hasModifier("override")
   }
 }
 
diff --git a/java/ql/test/kotlin/query-tests/UselessParameter/UselessParameter.expected b/java/ql/test/kotlin/query-tests/UselessParameter/UselessParameter.expected
@@ -1,2 +0,0 @@
-| Test.kt:6:27:6:30 | a | The parameter a is unused. |
-| Test.kt:6:33:6:38 | b | The parameter b is unused. |

Original file line number	Diff line number	Diff line change
`@@ -302,6 +302,8 @@ class RootdefCallable extends Callable {`
`302`	`302`	`exists(MemberRefExpr mre \| mre.getReferencedCallable() = this)`
`303`	`303`	`or`
`304`	`304`	`this.getAnAnnotation() instanceof OverrideAnnotation`
	`305`	`+ or`
	`306`	`+ this.hasModifier("override")`
`305`	`307`	`}`
`306`	`308`	`}`
`307`	`309`
Original file line number	Diff line number	Diff line change
`@@ -1,2 +0,0 @@`
`1`		`-\| Test.kt:6:27:6:30 \| a \| The parameter a is unused. \|`
`2`		`-\| Test.kt:6:33:6:38 \| b \| The parameter b is unused. \|`