Remove no-longer-applicable diagnostic matches

smowton · smowton · commit 5e023bf6197b · 2022-12-06T18:35:04.000Z
These resulted from the Java compiler exploring NotNull and other Kotlin-emitted annotations, which it no longer does because it finds a .class trap file already present and truncates its class-graph walk
diff --git a/java/ql/test/kotlin/library-tests/annotations/jvmName/test.kt b/java/ql/test/kotlin/library-tests/annotations/jvmName/test.kt
@@ -16,9 +16,3 @@ class X {
 annotation class Ann(
     val p: Int,
     @get:JvmName("w") val q: Int)
-
-// Diagnostic Matches: Incomplete annotation: @kotlin.jvm.JvmName(name="changeY")
-// Diagnostic Matches: Incomplete annotation: @kotlin.jvm.JvmName(name="getX_prop")
-// Diagnostic Matches: Incomplete annotation: @kotlin.jvm.JvmName(name="method")
-// Diagnostic Matches: Incomplete annotation: @kotlin.jvm.JvmName(name="y")
-// Diagnostic Matches: Unknown location for kotlin.jvm.JvmName
diff --git a/java/ql/test/kotlin/library-tests/arrays-with-variances/takesArrayList.kt b/java/ql/test/kotlin/library-tests/arrays-with-variances/takesArrayList.kt
@@ -110,6 +110,3 @@ public class TakesArrayList {
   fun inInArrayComparableAny(c: Comparable<Array<in Array<in Any>>>) { }
 
 }
-
-// Diagnostic Matches: Completion failure for type: org.jetbrains.annotations.NotNull
-// Diagnostic Matches: Unknown location for org.jetbrains.annotations.NotNull
diff --git a/java/ql/test/kotlin/library-tests/extensions/extensions.kt b/java/ql/test/kotlin/library-tests/extensions/extensions.kt
@@ -30,6 +30,3 @@ fun foo() {
     fun String.baz(p1: String): String { return "Baz" }
     "someString".baz("bazParam")
 }
-
-// Diagnostic Matches: Completion failure for type: org.jetbrains.annotations.NotNull
-// Diagnostic Matches: Unknown location for org.jetbrains.annotations.NotNull
diff --git a/java/ql/test/kotlin/library-tests/jvmoverloads_generics/test.kt b/java/ql/test/kotlin/library-tests/jvmoverloads_generics/test.kt
@@ -4,8 +4,3 @@ public class A {
   fun <T> genericFunctionWithOverloads(x: T? = null, y: List<T>? = null, z: T? = null): T? = z
 
 }
-
-// Diagnostic Matches: Completion failure for type: kotlin.jvm.JvmOverloads
-// Diagnostic Matches: Completion failure for type: org.jetbrains.annotations.Nullable
-// Diagnostic Matches: Unknown location for kotlin.jvm.JvmOverloads
-// Diagnostic Matches: Unknown location for org.jetbrains.annotations.Nullable

Original file line number	Diff line number	Diff line change
`@@ -110,6 +110,3 @@ public class TakesArrayList {`
`110`	`110`	`fun inInArrayComparableAny(c: Comparable<Array<in Array<in Any>>>) { }`
`111`	`111`
`112`	`112`	`}`
`113`		`-`
`114`		`-// Diagnostic Matches: Completion failure for type: org.jetbrains.annotations.NotNull`
`115`		`-// Diagnostic Matches: Unknown location for org.jetbrains.annotations.NotNull`
Original file line number	Diff line number	Diff line change
`@@ -30,6 +30,3 @@ fun foo() {`
`30`	`30`	`fun String.baz(p1: String): String { return "Baz" }`
`31`	`31`	`"someString".baz("bazParam")`
`32`	`32`	`}`
`33`		`-`
`34`		`-// Diagnostic Matches: Completion failure for type: org.jetbrains.annotations.NotNull`
`35`		`-// Diagnostic Matches: Unknown location for org.jetbrains.annotations.NotNull`
Original file line number	Diff line number	Diff line change
`@@ -4,8 +4,3 @@ public class A {`
`4`	`4`	`fun <T> genericFunctionWithOverloads(x: T? = null, y: List<T>? = null, z: T? = null): T? = z`
`5`	`5`
`6`	`6`	`}`
`7`		`-`
`8`		`-// Diagnostic Matches: Completion failure for type: kotlin.jvm.JvmOverloads`
`9`		`-// Diagnostic Matches: Completion failure for type: org.jetbrains.annotations.Nullable`
`10`		`-// Diagnostic Matches: Unknown location for kotlin.jvm.JvmOverloads`
`11`		`-// Diagnostic Matches: Unknown location for org.jetbrains.annotations.Nullable`