Stub unsafe modifier

tamasvajk · tamasvajk · commit 5e07d82b424c · 2021-06-23T09:26:53.000+02:00
diff --git a/csharp/ql/src/Stubs/Stubs.qll b/csharp/ql/src/Stubs/Stubs.qll
@@ -319,7 +319,11 @@ private string stubAccessibility(Member m) {
 }
 
 private string stubModifiers(Member m) {
-  result = stubAccessibility(m) + stubStaticOrConst(m) + stubOverride(m)
+  result = stubUnsafe(m) + stubAccessibility(m) + stubStaticOrConst(m) + stubOverride(m)
+}
+
+private string stubUnsafe(Member m) {
+  if m.(Modifiable).isUnsafe() then result = "unsafe " else result = ""
 }
 
 private string stubStaticOrConst(Member m) {
diff --git a/csharp/ql/src/Stubs/make_stubs_nuget.py b/csharp/ql/src/Stubs/make_stubs_nuget.py
@@ -67,7 +67,7 @@
                 '--include', outputName + '.cs'])
 
 print("\n* Building output project")
-helpers.run_cmd(['dotnet', 'build', '/t:rebuild', projectDirOut],
+helpers.run_cmd(['dotnet', 'build', '/t:rebuild', '/p:AllowUnsafeBlocks=true', projectDirOut],
                 'ERR: Build failed. Script failed to generate a stub that builds')
 
 print("\n --> Generated output file: " + outputFile)

Original file line number	Diff line number	Diff line change
`@@ -319,7 +319,11 @@ private string stubAccessibility(Member m) {`
`319`	`319`	`}`
`320`	`320`
`321`	`321`	`private string stubModifiers(Member m) {`
`322`		`- result = stubAccessibility(m) + stubStaticOrConst(m) + stubOverride(m)`
	`322`	`+ result = stubUnsafe(m) + stubAccessibility(m) + stubStaticOrConst(m) + stubOverride(m)`
	`323`	`+}`
	`324`	`+`
	`325`	`+private string stubUnsafe(Member m) {`
	`326`	`+ if m.(Modifiable).isUnsafe() then result = "unsafe " else result = ""`
`323`	`327`	`}`
`324`	`328`
`325`	`329`	`private string stubStaticOrConst(Member m) {`