Make the Config module of public Flow modules public

egregius313 · egregius313 · commit 60a4a795379f · 2023-03-20T07:47:55.000-04:00
This is to make things easier for the CodeML/ATM team once these
configurations are moved from `src/` to `lib/`.
diff --git a/java/ql/lib/semmle/code/java/security/XxeLocalQuery.qll b/java/ql/lib/semmle/code/java/security/XxeLocalQuery.qll
@@ -24,7 +24,7 @@ deprecated class XxeLocalConfig extends TaintTracking::Configuration {
   }
 }
 
-private module XxeLocalConfig implements DataFlow::ConfigSig {
+module XxeLocalConfig implements DataFlow::ConfigSig {
   predicate isSource(DataFlow::Node src) { src instanceof LocalUserInput }
 
   predicate isSink(DataFlow::Node sink) { sink instanceof XxeSink }
diff --git a/java/ql/lib/semmle/code/java/security/XxeRemoteQuery.qll b/java/ql/lib/semmle/code/java/security/XxeRemoteQuery.qll
@@ -24,7 +24,7 @@ deprecated class XxeConfig extends TaintTracking::Configuration {
   }
 }
 
-private module XxeConfig implements DataFlow::ConfigSig {
+module XxeConfig implements DataFlow::ConfigSig {
   predicate isSource(DataFlow::Node src) { src instanceof RemoteFlowSource }
 
   predicate isSink(DataFlow::Node sink) { sink instanceof XxeSink }
diff --git a/java/ql/src/Security/CWE/CWE-022/TaintedPathLocal.ql b/java/ql/src/Security/CWE/CWE-022/TaintedPathLocal.ql
@@ -20,7 +20,7 @@ import semmle.code.java.security.PathCreation
 import semmle.code.java.security.PathSanitizer
 import TaintedPathCommon
 
-private module TaintedPathLocalConfig implements DataFlow::ConfigSig {
+module TaintedPathLocalConfig implements DataFlow::ConfigSig {
   predicate isSource(DataFlow::Node source) { source instanceof LocalUserInput }
 
   predicate isSink(DataFlow::Node sink) {
diff --git a/java/ql/src/Security/CWE/CWE-022/ZipSlip.ql b/java/ql/src/Security/CWE/CWE-022/ZipSlip.ql
@@ -34,7 +34,7 @@ class ArchiveEntryNameMethod extends Method {
   }
 }
 
-private module ZipSlipConfiguration implements DataFlow::ConfigSig {
+module ZipSlipConfiguration implements DataFlow::ConfigSig {
   predicate isSource(DataFlow::Node source) {
     source.asExpr().(MethodAccess).getMethod() instanceof ArchiveEntryNameMethod
   }
diff --git a/java/ql/src/Security/CWE/CWE-090/LdapInjectionLib.qll b/java/ql/src/Security/CWE/CWE-090/LdapInjectionLib.qll
@@ -5,7 +5,7 @@ import semmle.code.java.security.LdapInjection
 /**
  * A taint-tracking configuration for unvalidated user input that is used to construct LDAP queries.
  */
-private module LdapInjectionFlowConfig implements DataFlow::ConfigSig {
+module LdapInjectionFlowConfig implements DataFlow::ConfigSig {
   predicate isSource(DataFlow::Node source) { source instanceof RemoteFlowSource }
 
   predicate isSink(DataFlow::Node sink) { sink instanceof LdapInjectionSink }
diff --git a/java/ql/src/Security/CWE/CWE-094/InsecureBeanValidation.ql b/java/ql/src/Security/CWE/CWE-094/InsecureBeanValidation.ql
@@ -55,7 +55,7 @@ class SetMessageInterpolatorCall extends MethodAccess {
  * Taint tracking BeanValidationConfiguration describing the flow of data from user input
  * to the argument of a method that builds constraint error messages.
  */
-private module BeanValidationConfig implements DataFlow::ConfigSig {
+module BeanValidationConfig implements DataFlow::ConfigSig {
   predicate isSource(DataFlow::Node source) { source instanceof RemoteFlowSource }
 
   predicate isSink(DataFlow::Node sink) { sink instanceof BeanValidationSink }
diff --git a/java/ql/src/Security/CWE/CWE-134/ExternallyControlledFormatStringLocal.ql b/java/ql/src/Security/CWE/CWE-134/ExternallyControlledFormatStringLocal.ql
@@ -14,7 +14,7 @@ import java
 import semmle.code.java.dataflow.FlowSources
 import semmle.code.java.StringFormat
 
-private module ExternallyControlledFormatStringLocalConfig implements DataFlow::ConfigSig {
+module ExternallyControlledFormatStringLocalConfig implements DataFlow::ConfigSig {
   predicate isSource(DataFlow::Node source) { source instanceof LocalUserInput }
 
   predicate isSink(DataFlow::Node sink) {
diff --git a/java/ql/src/Security/CWE/CWE-190/ArithmeticTaintedLocal.ql b/java/ql/src/Security/CWE/CWE-190/ArithmeticTaintedLocal.ql
@@ -16,7 +16,7 @@ import java
 import semmle.code.java.dataflow.FlowSources
 import ArithmeticCommon
 
-private module ArithmeticTaintedLocalOverflowConfig implements DataFlow::ConfigSig {
+module ArithmeticTaintedLocalOverflowConfig implements DataFlow::ConfigSig {
   predicate isSource(DataFlow::Node source) { source instanceof LocalUserInput }
 
   predicate isSink(DataFlow::Node sink) { overflowSink(_, sink.asExpr()) }
@@ -27,7 +27,7 @@ private module ArithmeticTaintedLocalOverflowConfig implements DataFlow::ConfigS
 module ArithmeticTaintedLocalOverflowFlow =
   TaintTracking::Make<ArithmeticTaintedLocalOverflowConfig>;
 
-private module ArithmeticTaintedLocalUnderflowConfig implements DataFlow::ConfigSig {
+module ArithmeticTaintedLocalUnderflowConfig implements DataFlow::ConfigSig {
   predicate isSource(DataFlow::Node source) { source instanceof LocalUserInput }
 
   predicate isSink(DataFlow::Node sink) { underflowSink(_, sink.asExpr()) }
diff --git a/java/ql/src/Security/CWE/CWE-190/ArithmeticUncontrolled.ql b/java/ql/src/Security/CWE/CWE-190/ArithmeticUncontrolled.ql
@@ -24,7 +24,7 @@ class TaintSource extends DataFlow::ExprNode {
   }
 }
 
-private module ArithmeticUncontrolledOverflowConfig implements DataFlow::ConfigSig {
+module ArithmeticUncontrolledOverflowConfig implements DataFlow::ConfigSig {
   predicate isSource(DataFlow::Node source) { source instanceof TaintSource }
 
   predicate isSink(DataFlow::Node sink) { overflowSink(_, sink.asExpr()) }
@@ -35,7 +35,7 @@ private module ArithmeticUncontrolledOverflowConfig implements DataFlow::ConfigS
 module ArithmeticUncontrolledOverflowFlow =
   TaintTracking::Make<ArithmeticUncontrolledOverflowConfig>;
 
-private module ArithmeticUncontrolledUnderflowConfig implements DataFlow::ConfigSig {
+module ArithmeticUncontrolledUnderflowConfig implements DataFlow::ConfigSig {
   predicate isSource(DataFlow::Node source) { source instanceof TaintSource }
 
   predicate isSink(DataFlow::Node sink) { underflowSink(_, sink.asExpr()) }
diff --git a/java/ql/src/Security/CWE/CWE-200/AndroidWebViewSettingsAllowsContentAccess.ql b/java/ql/src/Security/CWE/CWE-200/AndroidWebViewSettingsAllowsContentAccess.ql
@@ -65,7 +65,7 @@ private newtype WebViewOrSettings =
   IsWebView() or
   IsSettings()
 
-private module WebViewDisallowContentAccessConfig implements DataFlow::StateConfigSig {
+module WebViewDisallowContentAccessConfig implements DataFlow::StateConfigSig {
   class FlowState = WebViewOrSettings;
 
   predicate isSource(DataFlow::Node node, FlowState state) {
diff --git a/java/ql/src/Security/CWE/CWE-297/UnsafeHostnameVerification.ql b/java/ql/src/Security/CWE/CWE-297/UnsafeHostnameVerification.ql
@@ -44,7 +44,7 @@ class TrustAllHostnameVerifier extends RefType {
 /**
  * A configuration to model the flow of a `TrustAllHostnameVerifier` to a `set(Default)HostnameVerifier` call.
  */
-private module TrustAllHostnameVerifierConfig implements DataFlow::ConfigSig {
+module TrustAllHostnameVerifierConfig implements DataFlow::ConfigSig {
   predicate isSource(DataFlow::Node source) {
     source.asExpr().(ClassInstanceExpr).getConstructedType() instanceof TrustAllHostnameVerifier
   }
diff --git a/java/ql/src/Security/CWE/CWE-601/UrlRedirect.ql b/java/ql/src/Security/CWE/CWE-601/UrlRedirect.ql
@@ -15,7 +15,7 @@ import java
 import semmle.code.java.dataflow.FlowSources
 import semmle.code.java.security.UrlRedirect
 
-private module UrlRedirectConfig implements DataFlow::ConfigSig {
+module UrlRedirectConfig implements DataFlow::ConfigSig {
   predicate isSource(DataFlow::Node source) { source instanceof RemoteFlowSource }
 
   predicate isSink(DataFlow::Node sink) { sink instanceof UrlRedirectSink }
diff --git a/java/ql/src/Security/CWE/CWE-601/UrlRedirectLocal.ql b/java/ql/src/Security/CWE/CWE-601/UrlRedirectLocal.ql
@@ -15,7 +15,7 @@ import java
 import semmle.code.java.dataflow.FlowSources
 import semmle.code.java.security.UrlRedirect
 
-private module UrlRedirectLocalConfig implements DataFlow::ConfigSig {
+module UrlRedirectLocalConfig implements DataFlow::ConfigSig {
   predicate isSource(DataFlow::Node source) { source instanceof LocalUserInput }
 
   predicate isSink(DataFlow::Node sink) { sink instanceof UrlRedirectSink }
diff --git a/java/ql/src/Security/CWE/CWE-643/XPathInjection.ql b/java/ql/src/Security/CWE/CWE-643/XPathInjection.ql
@@ -16,7 +16,7 @@ import semmle.code.java.dataflow.FlowSources
 import semmle.code.java.dataflow.TaintTracking
 import semmle.code.java.security.XPath
 
-private module XPathInjectionConfig implements DataFlow::ConfigSig {
+module XPathInjectionConfig implements DataFlow::ConfigSig {
   predicate isSource(DataFlow::Node source) { source instanceof RemoteFlowSource }
 
   predicate isSink(DataFlow::Node sink) { sink instanceof XPathInjectionSink }
diff --git a/java/ql/src/Security/CWE/CWE-807/TaintedPermissionsCheck.ql b/java/ql/src/Security/CWE/CWE-807/TaintedPermissionsCheck.ql
@@ -52,7 +52,7 @@ class WCPermissionConstruction extends ClassInstanceExpr, PermissionsConstructio
   override Expr getInput() { result = this.getArgument(0) }
 }
 
-private module TaintedPermissionsCheckFlowConfig implements DataFlow::ConfigSig {
+module TaintedPermissionsCheckFlowConfig implements DataFlow::ConfigSig {
   predicate isSource(DataFlow::Node source) { source instanceof UserInput }
 
   predicate isSink(DataFlow::Node sink) {

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ deprecated class XxeLocalConfig extends TaintTracking::Configuration {`
`24`	`24`	`}`
`25`	`25`	`}`
`26`	`26`
`27`		`-private module XxeLocalConfig implements DataFlow::ConfigSig {`
	`27`	`+module XxeLocalConfig implements DataFlow::ConfigSig {`
`28`	`28`	`predicate isSource(DataFlow::Node src) { src instanceof LocalUserInput }`
`29`	`29`
`30`	`30`	`predicate isSink(DataFlow::Node sink) { sink instanceof XxeSink }`
Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ deprecated class XxeConfig extends TaintTracking::Configuration {`
`24`	`24`	`}`
`25`	`25`	`}`
`26`	`26`
`27`		`-private module XxeConfig implements DataFlow::ConfigSig {`
	`27`	`+module XxeConfig implements DataFlow::ConfigSig {`
`28`	`28`	`predicate isSource(DataFlow::Node src) { src instanceof RemoteFlowSource }`
`29`	`29`
`30`	`30`	`predicate isSink(DataFlow::Node sink) { sink instanceof XxeSink }`
Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ class ArchiveEntryNameMethod extends Method {`
`34`	`34`	`}`
`35`	`35`	`}`
`36`	`36`
`37`		`-private module ZipSlipConfiguration implements DataFlow::ConfigSig {`
	`37`	`+module ZipSlipConfiguration implements DataFlow::ConfigSig {`
`38`	`38`	`predicate isSource(DataFlow::Node source) {`
`39`	`39`	`source.asExpr().(MethodAccess).getMethod() instanceof ArchiveEntryNameMethod`
`40`	`40`	`}`
Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ class TaintSource extends DataFlow::ExprNode {`
`24`	`24`	`}`
`25`	`25`	`}`
`26`	`26`
`27`		`-private module ArithmeticUncontrolledOverflowConfig implements DataFlow::ConfigSig {`
	`27`	`+module ArithmeticUncontrolledOverflowConfig implements DataFlow::ConfigSig {`
`28`	`28`	`predicate isSource(DataFlow::Node source) { source instanceof TaintSource }`
`29`	`29`
`30`	`30`	`predicate isSink(DataFlow::Node sink) { overflowSink(_, sink.asExpr()) }`
`@@ -35,7 +35,7 @@ private module ArithmeticUncontrolledOverflowConfig implements DataFlow::ConfigS`
`35`	`35`	`module ArithmeticUncontrolledOverflowFlow =`
`36`	`36`	`TaintTracking::Make<ArithmeticUncontrolledOverflowConfig>;`
`37`	`37`
`38`		`-private module ArithmeticUncontrolledUnderflowConfig implements DataFlow::ConfigSig {`
	`38`	`+module ArithmeticUncontrolledUnderflowConfig implements DataFlow::ConfigSig {`
`39`	`39`	`predicate isSource(DataFlow::Node source) { source instanceof TaintSource }`
`40`	`40`
`41`	`41`	`predicate isSink(DataFlow::Node sink) { underflowSink(_, sink.asExpr()) }`