Apply changes from code review

edvraa · edvraa · commit 6393dca22f04 · 2021-07-12T01:13:41.000+03:00
diff --git a/csharp/ql/src/experimental/dataflow/flowsources/AuthCookie.qll b/csharp/ql/src/experimental/dataflow/flowsources/AuthCookie.qll
@@ -52,7 +52,6 @@ class CookieOptionsTrackingConfiguration extends DataFlow::Configuration {
   override predicate isSink(DataFlow::Node sink) {
     exists(MicrosoftAspNetCoreHttpResponseCookies iResponse, MethodCall mc |
       iResponse.getAppendMethod() = mc.getTarget() and
-      mc.getNumberOfArguments() > 2 and
       mc.getArgument(2) = sink.asExpr()
     )
   }
@@ -144,7 +143,7 @@ class OnAppendCookieHttpOnlyTrackingConfig extends OnAppendCookieTrackingConfig
 /**
  * Tracks if a callback used in `OnAppendCookie` sets a cookie property to `true`.
  */
-abstract class OnAppendCookieTrackingConfig extends DataFlow::Configuration {
+private abstract class OnAppendCookieTrackingConfig extends DataFlow::Configuration {
   bindingset[this]
   OnAppendCookieTrackingConfig() { any() }
 
