JS: Rename getResponseFormat => getResponseType

asger-semmle · asger-semmle · commit 64f1260220c0 · 2019-08-06T15:28:53.000+01:00
diff --git a/javascript/ql/src/semmle/javascript/frameworks/ClientRequests.qll b/javascript/ql/src/semmle/javascript/frameworks/ClientRequests.qll
@@ -142,20 +142,20 @@ module ClientRequest {
 
     override DataFlow::Node getHost() { none() }
 
-    string getResponseFormat() {
+    string getResponseType() {
       if getOptionArgument(1, "json").mayHaveBooleanValue(true) then
         result = "json"
       else
         result = "text"
     }
 
     override DataFlow::Node getAResponseDataNode(string responseType, boolean pr) {
-      responseType = getResponseFormat() and
+      responseType = getResponseType() and
       promise = true and
       pr = true and
       result = this
       or
-      responseType = getResponseFormat() and
+      responseType = getResponseType() and
       promise = false and
       pr = false and
       (
@@ -215,7 +215,7 @@ module ClientRequest {
       )
     }
 
-    string getResponseFormat() {
+    string getResponseType() {
       exists(DataFlow::Node option | option = getOptionArgument([0 .. 2], "responseType") |
         result = option.getStringValue()
         or
@@ -228,7 +228,7 @@ module ClientRequest {
     }
 
     override DataFlow::Node getAResponseDataNode(string responseType, boolean promise) {
-      responseType = getResponseFormat() and
+      responseType = getResponseType() and
       promise = true and
       result = this
     }
